diff options
author | Tejun Heo <tj@kernel.org> | 2019-10-24 22:03:51 +0300 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2019-10-25 15:56:28 +0300 |
commit | 5153faac18d293fc7abb19ff7034683fbcd82dc7 (patch) | |
tree | 485462f8daa9a37a6c5e6f8f70f2f4abcaa38099 /kernel/cgroup/cpuset.c | |
parent | a713af394cf382a30dd28a1015cbe572f1b9ca75 (diff) | |
download | linux-5153faac18d293fc7abb19ff7034683fbcd82dc7.tar.xz |
cgroup: remove cgroup_enable_task_cg_lists() optimization
cgroup_enable_task_cg_lists() is used to lazyily initialize task
cgroup associations on the first use to reduce fork / exit overheads
on systems which don't use cgroup. Unfortunately, locking around it
has never been actually correct and its value is dubious given how the
vast majority of systems use cgroup right away from boot.
This patch removes the optimization. For now, replace the cg_list
based branches with WARN_ON_ONCE()'s to be on the safe side. We can
simplify the logic further in the future.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/cgroup/cpuset.c')
-rw-r--r-- | kernel/cgroup/cpuset.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index c52bc91f882b..faff8f99e8f2 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -928,8 +928,6 @@ static void rebuild_root_domains(void) lockdep_assert_cpus_held(); lockdep_assert_held(&sched_domains_mutex); - cgroup_enable_task_cg_lists(); - rcu_read_lock(); /* |