summaryrefslogtreecommitdiff
path: root/kernel/events/callchain.c
diff options
context:
space:
mode:
authorNamhyung Kim <namhyung.kim@lge.com>2012-01-20 05:12:45 +0400
committerIngo Molnar <mingo@elte.hu>2012-01-21 12:33:41 +0400
commitfd45c15f13e754f3c106427e857310f3e0813951 (patch)
tree18c02a2b1037b773813b2f20fc4d826d7645ad96 /kernel/events/callchain.c
parentdcd6c92267155e70a94b3927bce681ce74b80d1f (diff)
downloadlinux-fd45c15f13e754f3c106427e857310f3e0813951.tar.xz
perf: Don't call release_callchain_buffers() if allocation fails
When alloc_callchain_buffers() fails, it frees all of entries before return. In addition, calling the release_callchain_buffers() will cause a NULL pointer dereference since callchain_cpu_entries is not set. Signed-off-by: Namhyung Kim <namhyung.kim@lge.com> Acked-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Link: http://lkml.kernel.org/r/1327021966-27688-1-git-send-email-namhyung.kim@lge.com Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/events/callchain.c')
-rw-r--r--kernel/events/callchain.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 057e24b665cf..6581a040f399 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -115,8 +115,6 @@ int get_callchain_buffers(void)
}
err = alloc_callchain_buffers();
- if (err)
- release_callchain_buffers();
exit:
mutex_unlock(&callchain_mutex);