diff options
author | Will Deacon <will@kernel.org> | 2023-02-01 01:17:19 +0300 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2023-02-06 23:18:36 +0300 |
commit | 7a2127e66a00e073db8d90f9aac308f4a8a64226 (patch) | |
tree | 709b980cc26b5635360dd50741fd0b1e45768a29 /kernel/smpboot.h | |
parent | 3fb906e7fabbb5b76c3c5256b10dc46ef80a0bfe (diff) | |
download | linux-7a2127e66a00e073db8d90f9aac308f4a8a64226.tar.xz |
cpuset: Call set_cpus_allowed_ptr() with appropriate mask for task
set_cpus_allowed_ptr() will fail with -EINVAL if the requested
affinity mask is not a subset of the task_cpu_possible_mask() for the
task being updated. Consequently, on a heterogeneous system with cpusets
spanning the different CPU types, updates to the cgroup hierarchy can
silently fail to update task affinities when the effective affinity
mask for the cpuset is expanded.
For example, consider an arm64 system with 4 CPUs, where CPUs 2-3 are
the only cores capable of executing 32-bit tasks. Attaching a 32-bit
task to a cpuset containing CPUs 0-2 will correctly affine the task to
CPU 2. Extending the cpuset to CPUs 0-3, however, will fail to extend
the affinity mask of the 32-bit task because update_tasks_cpumask() will
pass the full 0-3 mask to set_cpus_allowed_ptr().
Extend update_tasks_cpumask() to take a temporary 'cpumask' paramater
and use it to mask the 'effective_cpus' mask with the possible mask for
each task being updated.
Fixes: 431c69fac05b ("cpuset: Honour task_cpu_possible_mask() in guarantee_online_cpus()")
Signed-off-by: Will Deacon <will@kernel.org>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/smpboot.h')
0 files changed, 0 insertions, 0 deletions