summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorVitor Massaru Iha <vitor@massaru.org>2020-10-15 15:08:51 +0300
committerShuah Khan <skhan@linuxfoundation.org>2020-10-16 22:25:14 +0300
commit294a7f1613ee49a608361bd319519561c0ca7e72 (patch)
treeeb25a15a536db08c327e535b45b6851760e976c9 /lib
parentd2585f5164c298aaaed14c2c8d313cbe7bd5b253 (diff)
downloadlinux-294a7f1613ee49a608361bd319519561c0ca7e72.tar.xz
lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE
A build condition was missing around a compilation test, this compilation test comes from the original test_bitfield code. And removed unnecessary code for this test. Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org> Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/ Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/bitfield_kunit.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/bitfield_kunit.c b/lib/bitfield_kunit.c
index d63a2be5aff8..1473d8b4bf0f 100644
--- a/lib/bitfield_kunit.c
+++ b/lib/bitfield_kunit.c
@@ -125,7 +125,7 @@ static void __init test_bitfields_variables(struct kunit *context)
CHECK(u64, 0x0000001f8000000ull);
}
-
+#ifdef TEST_BITFIELD_COMPILE
static void __init test_bitfields_compile(struct kunit *context)
{
/* these should fail compilation */
@@ -135,13 +135,11 @@ static void __init test_bitfields_compile(struct kunit *context)
/* this should at least give a warning */
u16_encode_bits(0, 0x60000);
}
+#endif
static struct kunit_case __refdata bitfields_test_cases[] = {
KUNIT_CASE(test_bitfields_constants),
KUNIT_CASE(test_bitfields_variables),
-#ifdef TEST_BITFIELD_COMPILE
- KUNIT_CASE(test_bitfields_compile),
-#endif
{}
};