summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2021-07-14 00:47:10 +0300
committerRichard Weinberger <richard@nod.at>2021-08-26 23:28:03 +0300
commitadf9ae0d159d3dc94f58d788fc4757c8749ac0df (patch)
tree5681fea906412292e6418aa8ff08bc03666bc1e5 /lib
parent6a241d2923c2c0f6893c78c79421ceb3935691fd (diff)
downloadlinux-adf9ae0d159d3dc94f58d788fc4757c8749ac0df.tar.xz
um: fix stub location calculation
In commit 9f0b4807a44f ("um: rework userspace stubs to not hard-code stub location") I changed stub_segv_handler() to do a calculation with a pointer to a stack variable to find the data page that we're using for the stack and the rest of the data. This same commit was meant to do it as well for stub_clone_handler(), but the change inadvertently went into commit 84b2789d6115 ("um: separate child and parent errors in clone stub") instead. This was reported to not be compiled correctly by gcc 5, causing the code to crash here. I'm not sure why, perhaps it's UB because the var isn't initialized? In any case, this trick always seemed bad, so just create a new inline function that does the calculation in assembly. Reported-by: subashab@codeaurora.org Fixes: 9f0b4807a44f ("um: rework userspace stubs to not hard-code stub location") Fixes: 84b2789d6115 ("um: separate child and parent errors in clone stub") Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions