summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorPavel Machek <pavel@suse.cz>2009-01-07 01:40:53 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-07 02:59:12 +0300
commite899aa823ad74860a17b541b0ad38f513728923d (patch)
tree019c4a1b7baafe9967aa50cc49e809c11d39f944 /lib
parentff083c8372f6312bb3a8c7f7b748920aeeb210c9 (diff)
downloadlinux-e899aa823ad74860a17b541b0ad38f513728923d.tar.xz
strict_strto* is not strict enough
It decodes "\n" as 0, which is bad, because stray echo into backlight will turn your backlight off, etc... Signed-off-by: Pavel Machek <pavel@suse.cz> Cc: Yi Yang <yi.y.yang@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/vsprintf.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 98d632277ca8..0fbd0121d91d 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -170,6 +170,8 @@ int strict_strtoul(const char *cp, unsigned int base, unsigned long *res)
return -EINVAL;
val = simple_strtoul(cp, &tail, base);
+ if (tail == cp)
+ return -EINVAL;
if ((*tail == '\0') ||
((len == (size_t)(tail - cp) + 1) && (*tail == '\n'))) {
*res = val;
@@ -241,6 +243,8 @@ int strict_strtoull(const char *cp, unsigned int base, unsigned long long *res)
return -EINVAL;
val = simple_strtoull(cp, &tail, base);
+ if (tail == cp)
+ return -EINVAL;
if ((*tail == '\0') ||
((len == (size_t)(tail - cp) + 1) && (*tail == '\n'))) {
*res = val;