summaryrefslogtreecommitdiff
path: root/mm/gup_test.h
diff options
context:
space:
mode:
authorRyan Roberts <ryan.roberts@arm.com>2023-06-02 12:29:47 +0300
committerAndrew Morton <akpm@linux-foundation.org>2023-06-10 02:25:55 +0300
commitc11d34fa139e4b0fb4249a30f37b178353533fa1 (patch)
tree3e2c41caa4d16a715bb784ad29a241f47b85670c /mm/gup_test.h
parentb3f78e74986546a6da5d28c24e627d95d17f79ec (diff)
downloadlinux-c11d34fa139e4b0fb4249a30f37b178353533fa1.tar.xz
mm/damon/ops-common: atomically test and clear young on ptes and pmds
It is racy to non-atomically read a pte, then clear the young bit, then write it back as this could discard dirty information. Further, it is bad practice to directly set a pte entry within a table. Instead clearing young must go through the arch-provided helper, ptep_test_and_clear_young() to ensure it is modified atomically and to give the arch code visibility and allow it to check (and potentially modify) the operation. Link: https://lkml.kernel.org/r/20230602092949.545577-3-ryan.roberts@arm.com Fixes: 3f49584b262c ("mm/damon: implement primitives for the virtual memory address spaces"). Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> Reviewed-by: Zi Yan <ziy@nvidia.com> Reviewed-by: SeongJae Park <sj@kernel.org> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> Cc: Christoph Hellwig <hch@lst.de> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Lorenzo Stoakes <lstoakes@gmail.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Uladzislau Rezki (Sony) <urezki@gmail.com> Cc: Yu Zhao <yuzhao@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/gup_test.h')
0 files changed, 0 insertions, 0 deletions