diff options
author | Lukas Wunner <lukas@wunner.de> | 2022-06-20 14:04:50 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-22 07:59:47 +0300 |
commit | 2642cc6c3bbe0900ba15bab078fd15ad8baccbc5 (patch) | |
tree | ca3f4fd5cf97b67653da8c31872fe9114211c47d /net/atm | |
parent | 69135c572d1f84261a6de2a1268513a7e71753e2 (diff) | |
download | linux-2642cc6c3bbe0900ba15bab078fd15ad8baccbc5.tar.xz |
net: phy: smsc: Disable Energy Detect Power-Down in interrupt mode
Simon reports that if two LAN9514 USB adapters are directly connected
without an intermediate switch, the link fails to come up and link LEDs
remain dark. The issue was introduced by commit 1ce8b37241ed ("usbnet:
smsc95xx: Forward PHY interrupts to PHY driver to avoid polling").
The PHY suffers from a known erratum wherein link detection becomes
unreliable if Energy Detect Power-Down is used. In poll mode, the
driver works around the erratum by briefly disabling EDPD for 640 msec
to detect a neighbor, then re-enabling it to save power.
In interrupt mode, no interrupt is signaled if EDPD is used by both link
partners, so it must not be enabled at all.
We'll recoup the power savings by enabling SUSPEND1 mode on affected
LAN95xx chips in a forthcoming commit.
Fixes: 1ce8b37241ed ("usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling")
Reported-by: Simon Han <z.han@kunbus.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/439a3f3168c2f9d44b5fd9bb8d2b551711316be6.1655714438.git.lukas@wunner.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/atm')
0 files changed, 0 insertions, 0 deletions