diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-01-06 02:11:16 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-01-06 14:59:10 +0300 |
commit | 1e3f407f3cacc5dcfe27166c412ed9bc263d82bf (patch) | |
tree | 0cd9e2a25732a0391f0d7bfcc588f4357760e9c1 /net/dsa/tag_rtl8_4.c | |
parent | c146f9bc195a9dc3ad7fd000a14540e7c9df952d (diff) | |
download | linux-1e3f407f3cacc5dcfe27166c412ed9bc263d82bf.tar.xz |
net: dsa: first set up shared ports, then non-shared ports
After commit a57d8c217aad ("net: dsa: flush switchdev workqueue before
tearing down CPU/DSA ports"), the port setup and teardown procedure
became asymmetric.
The fact of the matter is that user ports need the shared ports to be up
before they can be used for CPU-initiated termination. And since we
register net devices for the user ports, those won't be functional until
we also call the setup for the shared (CPU, DSA) ports. But we may do
that later, depending on the port numbering scheme of the hardware we
are dealing with.
It just makes sense that all shared ports are brought up before any user
port is. I can't pinpoint any issue due to the current behavior, but
let's change it nonetheless, for consistency's sake.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_rtl8_4.c')
0 files changed, 0 insertions, 0 deletions