summaryrefslogtreecommitdiff
path: root/net/ethtool/debug.c
diff options
context:
space:
mode:
authorMichal Kubecek <mkubecek@suse.cz>2020-03-12 23:07:38 +0300
committerDavid S. Miller <davem@davemloft.net>2020-03-13 01:32:32 +0300
commit98130546da115a8aab663bc0c0971cc0bcc50542 (patch)
treeb3da89cf289a1482be374774f6dc058a8e83daa6 /net/ethtool/debug.c
parentf8ab30477690bb156536a76686a5a766efe587f8 (diff)
downloadlinux-98130546da115a8aab663bc0c0971cc0bcc50542.tar.xz
ethtool: rename ethnl_parse_header() to ethnl_parse_header_dev_get()
Andrew Lunn pointed out that even if it's documented that ethnl_parse_header() takes reference to network device if it fills it into the target structure, its name doesn't make it apparent so that corresponding dev_put() looks like mismatched. Rename the function ethnl_parse_header_dev_get() to indicate that it takes a reference. Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethtool/debug.c')
-rw-r--r--net/ethtool/debug.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/net/ethtool/debug.c b/net/ethtool/debug.c
index aaef4843e6ba..87f288ee20c8 100644
--- a/net/ethtool/debug.c
+++ b/net/ethtool/debug.c
@@ -102,8 +102,10 @@ int ethnl_set_debug(struct sk_buff *skb, struct genl_info *info)
info->extack);
if (ret < 0)
return ret;
- ret = ethnl_parse_header(&req_info, tb[ETHTOOL_A_DEBUG_HEADER],
- genl_info_net(info), info->extack, true);
+ ret = ethnl_parse_header_dev_get(&req_info,
+ tb[ETHTOOL_A_DEBUG_HEADER],
+ genl_info_net(info), info->extack,
+ true);
if (ret < 0)
return ret;
dev = req_info.dev;