diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-02-22 13:50:19 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-02-26 14:46:13 +0300 |
| commit | 4ce5dc9316de50e0da84beafe55d1344f829cece (patch) | |
| tree | 1814f7e005c025df154aa3c56d79436ed0106c78 /net/ipv4/fib_trie.c | |
| parent | 0ac3fa0c3b365f97c3969f391edf7b44d3bb210d (diff) | |
| download | linux-4ce5dc9316de50e0da84beafe55d1344f829cece.tar.xz | |
inet: switch inet_dump_fib() to RCU protection
No longer hold RTNL while calling inet_dump_fib().
Also change return value for a completed dump:
Returning 0 instead of skb->len allows NLMSG_DONE
to be appended to the skb. User space does not have
to call us again to get a standalone NLMSG_DONE marker.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_trie.c')
| -rw-r--r-- | net/ipv4/fib_trie.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 0fc7ab5832d1..f474106464d2 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -2368,7 +2368,7 @@ int fib_table_dump(struct fib_table *tb, struct sk_buff *skb, * and key == 0 means the dump has wrapped around and we are done. */ if (count && !key) - return skb->len; + return 0; while ((l = leaf_walk_rcu(&tp, key)) != NULL) { int err; @@ -2394,7 +2394,7 @@ int fib_table_dump(struct fib_table *tb, struct sk_buff *skb, cb->args[3] = key; cb->args[2] = count; - return skb->len; + return 0; } void __init fib_trie_init(void) |