diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2024-04-03 17:36:25 +0300 |
---|---|---|
committer | Chuck Lever <chuck.lever@oracle.com> | 2024-04-04 16:43:02 +0300 |
commit | 05258a0a69b3c5d2c003f818702c0a52b6fea861 (patch) | |
tree | c76a5d2475d8a7f76086cb491949bc2e7619dbad /net/ipv4 | |
parent | 99dc2ef0397d082b63404c01cf841cf80f1418dc (diff) | |
download | linux-05258a0a69b3c5d2c003f818702c0a52b6fea861.tar.xz |
SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP
Jan Schunk reports that his small NFS servers suffer from memory
exhaustion after just a few days. A bisect shows that commit
e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single
sock_sendmsg() call") is the first bad commit.
That commit assumed that sock_sendmsg() releases all the pages in
the underlying bio_vec array, but the reality is that it doesn't.
svc_xprt_release() releases the rqst's response pages, but the
record marker page fragment isn't one of those, so it is never
released.
This is a narrow fix that can be applied to stable kernels. A
more extensive fix is in the works.
Reported-by: Jan Schunk <scpcom@gmx.de>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218671
Fixes: e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call")
Cc: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Jakub Kacinski <kuba@kernel.org>
Cc: David Howells <dhowells@redhat.com>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions