diff options
author | Vlad Buslov <vladbu@mellanox.com> | 2019-05-23 09:32:31 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-24 23:27:52 +0300 |
commit | 4097e9d250fb17958c1d9b94538386edd3f20144 (patch) | |
tree | ef1c2f78f301bc874193fae3b17cea81bfb0c882 /net/ipv6 | |
parent | ab0610efabb4c4f419a531455708caf1dd29357e (diff) | |
download | linux-4097e9d250fb17958c1d9b94538386edd3f20144.tar.xz |
net: sched: don't use tc_action->order during action dump
Function tcf_action_dump() relies on tc_action->order field when starting
nested nla to send action data to userspace. This approach breaks in
several cases:
- When multiple filters point to same shared action, tc_action->order field
is overwritten each time it is attached to filter. This causes filter
dump to output action with incorrect attribute for all filters that have
the action in different position (different order) from the last set
tc_action->order value.
- When action data is displayed using tc action API (RTM_GETACTION), action
order is overwritten by tca_action_gd() according to its position in
resulting array of nl attributes, which will break filter dump for all
filters attached to that shared action that expect it to have different
order value.
Don't rely on tc_action->order when dumping actions. Set nla according to
action position in resulting array of actions instead.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6')
0 files changed, 0 insertions, 0 deletions