diff options
author | Jarno Rajahalme <jarno@ovn.org> | 2016-03-21 21:15:19 +0300 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2016-03-28 18:58:51 +0300 |
commit | 5745b0be05a0f8ccbc92a36b69f3a6bc58e91954 (patch) | |
tree | 90a34624e8f665170cb9aa17a937ab9373177f82 /net/ipv6 | |
parent | 596cf3fe5854fe2b1703b0466ed6bf9cfb83c91e (diff) | |
download | linux-5745b0be05a0f8ccbc92a36b69f3a6bc58e91954.tar.xz |
openvswitch: Fix checking for new expected connections.
OVS should call into CT NAT for packets of new expected connections only
when the conntrack state is persisted with the 'commit' option to the
OVS CT action. The test for this condition is doubly wrong, as the CT
status field is ANDed with the bit number (IPS_EXPECTED_BIT) rather
than the mask (IPS_EXPECTED), and due to the wrong assumption that the
expected bit would apply only for the first (i.e., 'new') packet of a
connection, while in fact the expected bit remains on for the lifetime of
an expected connection. The 'ctinfo' value IP_CT_RELATED derived from
the ct status can be used instead, as it is only ever applicable to
the 'new' packets of the expected connection.
Fixes: 05752523e565 ('openvswitch: Interface with NAT.')
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/ipv6')
0 files changed, 0 insertions, 0 deletions