summaryrefslogtreecommitdiff
path: root/net/mac802154/rx.c
diff options
context:
space:
mode:
authorAlexander Aring <aahringo@redhat.com>2022-10-07 11:53:05 +0300
committerStefan Schmidt <stefan@datenfreihafen.org>2022-10-12 13:56:58 +0300
commitac8037c35bd1fb1799d39f52205f813e6585b58b (patch)
tree20a52887df9d124b23c82a54fc6d1c89d7be1b91 /net/mac802154/rx.c
parente9d8d9c4084dadfa5a68a2e6e4e4dda7a0a728ba (diff)
downloadlinux-ac8037c35bd1fb1799d39f52205f813e6585b58b.tar.xz
mac802154: set filter at drv_start()
The current filtering level is set on the first interface up on a wpan phy. If we support scan functionality we need to change the filtering level on the fly on an operational phy and switching back again. This patch will move the receive mode parameter e.g. address filter and promiscuous mode to the drv_start() functionality to allow changing the receive mode on an operational phy not on first ifup only. In future this should be handled on driver layer because each hardware has it's own way to enter a specific filtering level. However this should offer to switch to mode IEEE802154_FILTERING_NONE and back to IEEE802154_FILTERING_4_FRAME_FIELDS. Only IEEE802154_FILTERING_4_FRAME_FIELDS and IEEE802154_FILTERING_NONE are somewhat supported by current hardware. All other filtering levels can be supported in future but will end in IEEE802154_FILTERING_NONE as the receive part can kind of "emulate" those receive paths by doing additional filtering routines. There are in total three filtering levels in the code: - the per-interface default level (should not be changed) - the required per-interface level (mac commands may play with it) - the actual per-PHY (hw) level that is currently in use Signed-off-by: Alexander Aring <aahringo@redhat.com> [<miquel.raynal@bootlin.com: Add the third filtering variable] Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/r/20221007085310.503366-4-miquel.raynal@bootlin.com Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'net/mac802154/rx.c')
-rw-r--r--net/mac802154/rx.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
index b8ce84618a55..8543c28948a0 100644
--- a/net/mac802154/rx.c
+++ b/net/mac802154/rx.c
@@ -268,10 +268,20 @@ void ieee802154_rx(struct ieee802154_local *local, struct sk_buff *skb)
ieee802154_monitors_rx(local, skb);
+ /* TODO: Avoid delivering frames received at the level
+ * IEEE802154_FILTERING_NONE on interfaces not expecting it because of
+ * the missing auto ACK handling feature.
+ */
+
+ /* TODO: Handle upcomming receive path where the PHY is at the
+ * IEEE802154_FILTERING_NONE level during a scan.
+ */
+
/* Check if transceiver doesn't validate the checksum.
* If not we validate the checksum here.
*/
- if (local->hw.flags & IEEE802154_HW_RX_DROP_BAD_CKSUM) {
+ if (local->hw.flags & IEEE802154_HW_RX_DROP_BAD_CKSUM ||
+ local->phy->filtering == IEEE802154_FILTERING_NONE) {
crc = crc_ccitt(0, skb->data, skb->len);
if (crc) {
rcu_read_unlock();