summaryrefslogtreecommitdiff
path: root/net/phonet
diff options
context:
space:
mode:
authorDan Rosenberg <drosenberg@vsecurity.com>2010-10-01 15:51:47 +0400
committerDavid S. Miller <davem@davemloft.net>2010-10-04 08:58:49 +0400
commit51e97a12bef19b7e43199fc153cf9bd5f2140362 (patch)
tree1ac12f07ab40e28d3ec29d04384a17c3e3b33826 /net/phonet
parentd7e0d19aa0fdd22819d35db551bd54c1bcf9c2aa (diff)
downloadlinux-51e97a12bef19b7e43199fc153cf9bd5f2140362.tar.xz
sctp: Fix out-of-bounds reading in sctp_asoc_get_hmac()
The sctp_asoc_get_hmac() function iterates through a peer's hmac_ids array and attempts to ensure that only a supported hmac entry is returned. The current code fails to do this properly - if the last id in the array is out of range (greater than SCTP_AUTH_HMAC_ID_MAX), the id integer remains set after exiting the loop, and the address of an out-of-bounds entry will be returned and subsequently used in the parent function, causing potentially ugly memory corruption. This patch resets the id integer to 0 on encountering an invalid id so that NULL will be returned after finishing the loop if no valid ids are found. Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/phonet')
0 files changed, 0 insertions, 0 deletions