diff options
author | David Hildenbrand <david@redhat.com> | 2023-07-11 20:40:50 +0300 |
---|---|---|
committer | Andrew Morton <akpm@linux-foundation.org> | 2023-08-18 20:12:19 +0300 |
commit | de7cb03db05a4b460edefff266bbaead70a11634 (patch) | |
tree | 878b09c205806f8604ac60806a1ee7aa104b1f99 /net/sched | |
parent | d03668803bf03bd1353a902edfbc139a6a6c7bc1 (diff) | |
download | linux-de7cb03db05a4b460edefff266bbaead70a11634.tar.xz |
mm/memory_hotplug: document the signal_pending() check in offline_pages()
Let's update the documentation that any signal is sufficient, and add a
comment that not only checking for fatal signals is historical baggage:
changing it now could break existing user space. although unlikely.
For example, when an app provides a custom SIGALRM handler and triggers
memory offlining, the timeout cmd would no longer stop memory offlining,
because SIGALRM would no longer be considered a fatal signal.
Note that using signal_pending() instead of fatal_signal_pending() is
an anti-pattern, but slowly deprecating that behavior to eventually
change it in the far future is probably not worth the effort. If this
ever becomes relevant for user-space, we might want to rethink.
Link: https://lkml.kernel.org/r/20230711174050.603820-1-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'net/sched')
0 files changed, 0 insertions, 0 deletions