summaryrefslogtreecommitdiff
path: root/net/sunrpc/svc_xprt.c
diff options
context:
space:
mode:
authorTrond Myklebust <trondmy@gmail.com>2018-10-09 22:54:15 +0300
committerJ. Bruce Fields <bfields@redhat.com>2018-10-29 23:58:04 +0300
commitbb6ad5572c0022e17e846b382d7413cdcf8055be (patch)
tree9dd0c1cad4f1f1ae8188e3808a38aa0fdd7cf669 /net/sunrpc/svc_xprt.c
parentbd8d725078867cda250fe94b9c5a067b4a64ca74 (diff)
downloadlinux-bb6ad5572c0022e17e846b382d7413cdcf8055be.tar.xz
nfsd: Fix an Oops in free_session()
In call_xpt_users(), we delete the entry from the list, but we do not reinitialise it. This triggers the list poisoning when we later call unregister_xpt_user() in nfsd4_del_conns(). Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: stable@vger.kernel.org Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/svc_xprt.c')
-rw-r--r--net/sunrpc/svc_xprt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 5185efb9027b..83ccd0221c98 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -989,7 +989,7 @@ static void call_xpt_users(struct svc_xprt *xprt)
spin_lock(&xprt->xpt_lock);
while (!list_empty(&xprt->xpt_users)) {
u = list_first_entry(&xprt->xpt_users, struct svc_xpt_user, list);
- list_del(&u->list);
+ list_del_init(&u->list);
u->callback(u);
}
spin_unlock(&xprt->xpt_lock);