diff options
author | Geliang Tang <tanggeliang@kylinos.cn> | 2024-02-15 21:25:28 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2024-02-18 13:25:00 +0300 |
commit | 6c347be62ae963b301ead8e7fa7b9973e6e0d6e1 (patch) | |
tree | 05692c5b1ca59f4f732d1841b20c495ff44f4f44 /net/tls/tls_main.c | |
parent | 59a646d6c7e426c9ac8cd9f1cd13fe2096aa9dfc (diff) | |
download | linux-6c347be62ae963b301ead8e7fa7b9973e6e0d6e1.tar.xz |
mptcp: add needs_id for userspace appending addr
When userspace PM requires to create an ID 0 subflow in "userspace pm
create id 0 subflow" test like this:
userspace_pm_add_sf $ns2 10.0.3.2 0
An ID 1 subflow, in fact, is created.
Since in mptcp_pm_nl_append_new_local_addr(), 'id 0' will be treated as
no ID is set by userspace, and will allocate a new ID immediately:
if (!e->addr.id)
e->addr.id = find_next_zero_bit(pernet->id_bitmap,
MPTCP_PM_MAX_ADDR_ID + 1,
1);
To solve this issue, a new parameter needs_id is added for
mptcp_userspace_pm_append_new_local_addr() to distinguish between
whether userspace PM has set an ID 0 or whether userspace PM has
not set any address.
needs_id is true in mptcp_userspace_pm_get_local_id(), but false in
mptcp_pm_nl_announce_doit() and mptcp_pm_nl_subflow_create_doit().
Fixes: e5ed101a6028 ("mptcp: userspace pm allow creating id 0 subflow")
Cc: stable@vger.kernel.org
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls/tls_main.c')
0 files changed, 0 insertions, 0 deletions