diff options
author | Yan Zhai <yan@cloudflare.com> | 2023-08-18 05:58:11 +0300 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2023-08-18 17:05:26 +0300 |
commit | 29b22badb7a84b783e3a4fffca16f7768fb31205 (patch) | |
tree | 9129510d137e3e957f0d405d58e18723ce9a22a8 /net/vmw_vsock | |
parent | 5f6395fd06806a009b93436612768fe3777a154f (diff) | |
download | linux-29b22badb7a84b783e3a4fffca16f7768fb31205.tar.xz |
lwt: Fix return values of BPF xmit ops
BPF encap ops can return different types of positive values, such like
NET_RX_DROP, NET_XMIT_CN, NETDEV_TX_BUSY, and so on, from function
skb_do_redirect and bpf_lwt_xmit_reroute. At the xmit hook, such return
values would be treated implicitly as LWTUNNEL_XMIT_CONTINUE in
ip(6)_finish_output2. When this happens, skbs that have been freed would
continue to the neighbor subsystem, causing use-after-free bug and
kernel crashes.
To fix the incorrect behavior, skb_do_redirect return values can be
simply discarded, the same as tc-egress behavior. On the other hand,
bpf_lwt_xmit_reroute returns useful errors to local senders, e.g. PMTU
information. Thus convert its return values to avoid the conflict with
LWTUNNEL_XMIT_CONTINUE.
Fixes: 3a0af8fd61f9 ("bpf: BPF for lightweight tunnel infrastructure")
Reported-by: Jordan Griege <jgriege@cloudflare.com>
Suggested-by: Martin KaFai Lau <martin.lau@linux.dev>
Suggested-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Yan Zhai <yan@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/0d2b878186cfe215fec6b45769c1cd0591d3628d.1692326837.git.yan@cloudflare.com
Diffstat (limited to 'net/vmw_vsock')
0 files changed, 0 insertions, 0 deletions