diff options
author | Eric Dumazet <edumazet@google.com> | 2020-01-13 20:27:11 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-01-14 22:04:42 +0300 |
commit | f8d7408a4d7f60f8b2df0f81decdc882dd9c20dc (patch) | |
tree | 4e0109b6d619de6896dd63a004a862443d56cf21 /net/vmw_vsock | |
parent | 75718584cb3c64e6269109d4d54f888ac5a5fd15 (diff) | |
download | linux-f8d7408a4d7f60f8b2df0f81decdc882dd9c20dc.tar.xz |
net: usb: lan78xx: limit size of local TSO packets
lan78xx_tx_bh() makes sure to not exceed MAX_SINGLE_PACKET_SIZE
bytes in the aggregated packets it builds, but does
nothing to prevent large GSO packets being submitted.
Pierre-Francois reported various hangs when/if TSO is enabled.
For localy generated packets, we can use netif_set_gso_max_size()
to limit the size of TSO packets.
Note that forwarded packets could still hit the issue,
so a complete fix might require implementing .ndo_features_check
for this driver, forcing a software segmentation if the size
of the TSO packet exceeds MAX_SINGLE_PACKET_SIZE.
Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: RENARD Pierre-Francois <pfrenard@gmail.com>
Tested-by: RENARD Pierre-Francois <pfrenard@gmail.com>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Woojung Huh <woojung.huh@microchip.com>
Cc: Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/vmw_vsock')
0 files changed, 0 insertions, 0 deletions