summaryrefslogtreecommitdiff
path: root/samples
diff options
context:
space:
mode:
authorMasahiro Yamada <masahiroy@kernel.org>2022-06-06 07:53:55 +0300
committerJakub Kicinski <kuba@kernel.org>2022-06-08 20:10:14 +0300
commit5801f064e35181c71857a80ff18af4dbec3c5f5c (patch)
treef1b401ed37a3365a641fb10bc6626d972a377ad3 /samples
parent4a388f08d8784af48f352193d2b72aaf167a57a1 (diff)
downloadlinux-5801f064e35181c71857a80ff18af4dbec3c5f5c.tar.xz
net: ipv6: unexport __init-annotated seg6_hmac_init()
EXPORT_SYMBOL and __init is a bad combination because the .init.text section is freed up after the initialization. Hence, modules cannot use symbols annotated __init. The access to a freed symbol may end up with kernel panic. modpost used to detect it, but it has been broken for a decade. Recently, I fixed modpost so it started to warn it again, then this showed up in linux-next builds. There are two ways to fix it: - Remove __init - Remove EXPORT_SYMBOL I chose the latter for this case because the caller (net/ipv6/seg6.c) and the callee (net/ipv6/seg6_hmac.c) belong to the same module. It seems an internal function call in ipv6.ko. Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions