summaryrefslogtreecommitdiff
path: root/scripts/mod
diff options
context:
space:
mode:
authorBen Hutchings <ben@decadent.org.uk>2023-03-22 21:11:45 +0300
committerMasahiro Yamada <masahiroy@kernel.org>2023-03-23 09:28:41 +0300
commitfb27e70f6e408dee5d22b083e7a38a59e6118253 (patch)
tree6c95885eb53dc1619ff2748d5820146af4fd0831 /scripts/mod
parent1073c15fd39e804ad36ff26a7c7d53b0ab51b184 (diff)
downloadlinux-fb27e70f6e408dee5d22b083e7a38a59e6118253.tar.xz
modpost: Fix processing of CRCs on 32-bit build machines
modpost now reads CRCs from .*.cmd files, parsing them using strtol(). This is inconsistent with its parsing of Module.symvers and with their definition as *unsigned* 32-bit values. strtol() clamps values to [LONG_MIN, LONG_MAX], and when building on a 32-bit system this changes all CRCs >= 0x80000000 to be 0x7fffffff. Change extract_crcs_for_object() to use strtoul() instead. Cc: stable@vger.kernel.org Fixes: f292d875d0dc ("modpost: extract symbol versions from *.cmd files") Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/mod')
-rw-r--r--scripts/mod/modpost.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index efff8078e395..9466b6a2abae 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1733,7 +1733,7 @@ static void extract_crcs_for_object(const char *object, struct module *mod)
if (!isdigit(*p))
continue; /* skip this line */
- crc = strtol(p, &p, 0);
+ crc = strtoul(p, &p, 0);
if (*p != '\n')
continue; /* skip this line */