diff options
| author | Eric Dumazet <edumazet@google.com> | 2021-03-11 23:35:06 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-12 05:35:31 +0300 |
| commit | ac3959fd0dcc0e49298ea5cadfe257db0e58ef8b (patch) | |
| tree | 7c530d5490a1fc493fd3df9483501b01bd040d3a /security | |
| parent | a7abf3cd76e1e190a2c22afe5ffd0f695c7641b0 (diff) | |
| download | linux-ac3959fd0dcc0e49298ea5cadfe257db0e58ef8b.tar.xz | |
tcp: remove obsolete check in __tcp_retransmit_skb()
TSQ provides a nice way to avoid bufferbloat on individual socket,
including retransmit packets. We can get rid of the old
heuristic:
/* Do not sent more than we queued. 1/4 is reserved for possible
* copying overhead: fragmentation, tunneling, mangling etc.
*/
if (refcount_read(&sk->sk_wmem_alloc) >
min_t(u32, sk->sk_wmem_queued + (sk->sk_wmem_queued >> 2),
sk->sk_sndbuf))
return -EAGAIN;
This heuristic was giving false positives according to Jakub,
whenever TX completions are delayed above RTT. (Ack packets
are processed by TCP stack before clones are orphaned/freed)
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jakub Kicinski <kuba@kernel.org>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions