summaryrefslogtreecommitdiff
path: root/sound/aoa
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-10-27 04:34:38 +0300
committerTakashi Iwai <tiwai@suse.de>2022-10-27 09:27:39 +0300
commit4a4c8482e370d697738a78dcd7bf2780832cb712 (patch)
tree8500aa6cf1093f42e260ea909c5285fa3949ac1a /sound/aoa
parentf850a2b156448bd97c747f6206523886578850c7 (diff)
downloadlinux-4a4c8482e370d697738a78dcd7bf2780832cb712.tar.xz
ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()
dev_set_name() in soundbus_add_one() allocates memory for name, it need be freed when of_device_register() fails, call soundbus_dev_put() to give up the reference that hold in device_initialize(), so that it can be freed in kobject_cleanup() when the refcount hit to 0. And other resources are also freed in i2sbus_release_dev(), so it can return 0 directly. Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20221027013438.991920-1-yangyingliang@huawei.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/aoa')
-rw-r--r--sound/aoa/soundbus/i2sbus/core.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c
index faf6b03131ee..f6841daf9e3b 100644
--- a/sound/aoa/soundbus/i2sbus/core.c
+++ b/sound/aoa/soundbus/i2sbus/core.c
@@ -302,6 +302,10 @@ static int i2sbus_add_dev(struct macio_dev *macio,
if (soundbus_add_one(&dev->sound)) {
printk(KERN_DEBUG "i2sbus: device registration error!\n");
+ if (dev->sound.ofdev.dev.kobj.state_initialized) {
+ soundbus_dev_put(&dev->sound);
+ return 0;
+ }
goto err;
}