diff options
| author | Trevor Wu <trevor.wu@mediatek.com> | 2021-12-30 11:47:30 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-12-31 16:20:57 +0300 |
| commit | 2355028c0c54c03afb66c589347f1dc9f6fe2e38 (patch) | |
| tree | ba1595afb4e566242911622951882ea792bc72ea /sound/soc/mediatek/mt8195/mt8195-reg.h | |
| parent | cc5c9788106fb1b9e03c8c57d8d7166073a54416 (diff) | |
| download | linux-2355028c0c54c03afb66c589347f1dc9f6fe2e38.tar.xz | |
ASoC: mediatek: mt8195: correct pcmif BE dai control flow
Originally, the conditions for preventing reentry are not correct.
dai->component->active is not the state specifically for pcmif dai, so it
is not a correct condition to indicate the status of pcmif dai.
On the other hand, snd_soc_dai_stream_actvie() in prepare ops for both
playback and capture possibly return true at the first entry when these
two streams are opened at the same time.
In the patch, I refer to the implementation in mt8192-dai-pcm.c.
Clock and enabling bit for PCMIF are managed by DAPM, and the condition
for prepare ops is replaced by the status of dai widget.
Fixes: 1f95c019115c ("ASoC: mediatek: mt8195: support pcm in platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20211230084731.31372-2-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/mediatek/mt8195/mt8195-reg.h')
| -rw-r--r-- | sound/soc/mediatek/mt8195/mt8195-reg.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/mediatek/mt8195/mt8195-reg.h b/sound/soc/mediatek/mt8195/mt8195-reg.h index d06f9cf85a4e..d3871353db41 100644 --- a/sound/soc/mediatek/mt8195/mt8195-reg.h +++ b/sound/soc/mediatek/mt8195/mt8195-reg.h @@ -2550,6 +2550,7 @@ #define PCM_INTF_CON1_PCM_FMT(x) (((x) & 0x3) << 1) #define PCM_INTF_CON1_PCM_FMT_MASK (0x3 << 1) #define PCM_INTF_CON1_PCM_EN BIT(0) +#define PCM_INTF_CON1_PCM_EN_SHIFT 0 /* PCM_INTF_CON2 */ #define PCM_INTF_CON2_CLK_DOMAIN_SEL(x) (((x) & 0x3) << 23) |