summaryrefslogtreecommitdiff
path: root/tools/bpf/bpftool/perf.c
diff options
context:
space:
mode:
authorQuentin Monnet <quentin@isovalent.com>2020-05-23 04:07:51 +0300
committerAlexei Starovoitov <ast@kernel.org>2020-06-02 00:38:18 +0300
commit90040351a832acf862c8f1855c29411303d23755 (patch)
tree567809c56719ac0e38227d83459c76212de63d00 /tools/bpf/bpftool/perf.c
parenteae9d3c0167df840e821317040efcf0ca6789cb9 (diff)
downloadlinux-90040351a832acf862c8f1855c29411303d23755.tar.xz
tools, bpftool: Clean subcommand help messages
This is a clean-up for the formatting of the do_help functions for bpftool's subcommands. The following fixes are included: - Do not use argv[-2] for "iter" help message, as the help is shown by default if no "iter" action is selected, resulting in messages looking like "./bpftool bpftool pin...". - Do not print unused HELP_SPEC_PROGRAM in help message for "bpftool link". - Andrii used argument indexing to avoid having multiple occurrences of bin_name and argv[-2] in the fprintf() for the help message, for "bpftool gen" and "bpftool link". Let's reuse this for all other help functions. We can remove up to thirty arguments for the "bpftool map" help message. - Harmonise all functions, e.g. use ending quotes-comma on a separate line. Signed-off-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20200523010751.23465-1-quentin@isovalent.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'tools/bpf/bpftool/perf.c')
-rw-r--r--tools/bpf/bpftool/perf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/perf.c b/tools/bpf/bpftool/perf.c
index 3341aa14acda..ad23934819c7 100644
--- a/tools/bpf/bpftool/perf.c
+++ b/tools/bpf/bpftool/perf.c
@@ -231,7 +231,7 @@ static int do_show(int argc, char **argv)
static int do_help(int argc, char **argv)
{
fprintf(stderr,
- "Usage: %s %s { show | list | help }\n"
+ "Usage: %1$s %2$s { show | list | help }\n"
"",
bin_name, argv[-2]);