diff options
author | Fenghua Yu <fenghua.yu@intel.com> | 2021-03-17 05:22:38 +0300 |
---|---|---|
committer | Shuah Khan <skhan@linuxfoundation.org> | 2021-04-02 22:51:36 +0300 |
commit | 2428673638ea28fa93d2a38b1c3e8d70122b00ee (patch) | |
tree | ba40c64b21e5bcea79744d7bd9760fd1b4408068 /tools/testing/selftests/resctrl/mba_test.c | |
parent | 896016d2ad051811ff9c9c087393adc063322fbc (diff) | |
download | linux-2428673638ea28fa93d2a38b1c3e8d70122b00ee.tar.xz |
selftests/resctrl: Clean up resctrl features check
Checking resctrl features call strcmp() to compare feature strings
(e.g. "mba", "cat" etc). The checkings are error prone and don't have
good coding style. Define the constant strings in macros and call
strncmp() to solve the potential issues.
Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/resctrl/mba_test.c')
-rw-r--r-- | tools/testing/selftests/resctrl/mba_test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 7bf8eaa6204b..6449fbd96096 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -141,7 +141,7 @@ void mba_test_cleanup(void) int mba_schemata_change(int cpu_no, char *bw_report, char **benchmark_cmd) { struct resctrl_val_param param = { - .resctrl_val = "mba", + .resctrl_val = MBA_STR, .ctrlgrp = "c1", .mongrp = "m1", .cpu_no = cpu_no, |