summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/resctrl
diff options
context:
space:
mode:
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>2023-07-17 16:15:01 +0300
committerShuah Khan <skhan@linuxfoundation.org>2023-07-25 17:53:36 +0300
commit5e3e4f1a03f075bd49104ea4c998c20649a49491 (patch)
tree2456bf9cd4a85f1619c98f6c849d6572b3ce6115 /tools/testing/selftests/resctrl
parent326baed260e2e4f2df18d42d41b261740c6b8c04 (diff)
downloadlinux-5e3e4f1a03f075bd49104ea4c998c20649a49491.tar.xz
selftests/resctrl: Remove unnecessary startptr global from fill_buf
fill_buf stores buffer pointer into global variable startptr that is only used in fill_cache(). Remove startptr as global variable, the local variable in fill_cache() is enough to keep the pointer. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Tested-by: Babu Moger <babu.moger@amd.com> Tested-by: Shaopeng Tan (Fujitsu) <tan.shaopeng@fujitsu.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/resctrl')
-rw-r--r--tools/testing/selftests/resctrl/fill_buf.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
index d8f5505eb9e6..a5ec9c82a960 100644
--- a/tools/testing/selftests/resctrl/fill_buf.c
+++ b/tools/testing/selftests/resctrl/fill_buf.c
@@ -22,8 +22,6 @@
#define PAGE_SIZE (4 * 1024)
#define MB (1024 * 1024)
-static unsigned char *startptr;
-
static void sb(void)
{
#if defined(__i386) || defined(__x86_64)
@@ -147,7 +145,6 @@ static int fill_cache(size_t buf_size, int memflush, int op, char *resctrl_val)
if (!start_ptr)
return -1;
- startptr = start_ptr;
end_ptr = start_ptr + buf_size;
/* Flush the memory before using to avoid "cache hot pages" effect */
@@ -159,7 +156,7 @@ static int fill_cache(size_t buf_size, int memflush, int op, char *resctrl_val)
else
ret = fill_cache_write(start_ptr, end_ptr, resctrl_val);
- free(startptr);
+ free(start_ptr);
if (ret) {
printf("\n Error in fill cache read/write...\n");