diff options
author | Tejun Heo <tj@kernel.org> | 2012-02-29 00:56:21 +0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2012-03-01 13:53:18 +0400 |
commit | 847854f5988a04fe7e02d2fdd4fa0df9f96360fe (patch) | |
tree | c1c1e4de2f0221b63d359961e54d2977d90b9536 /tools | |
parent | 88ebdda6159ffc15699f204c33feb3e431bf9bdc (diff) | |
download | linux-847854f5988a04fe7e02d2fdd4fa0df9f96360fe.tar.xz |
memblock: Fix size aligning of memblock_alloc_base_nid()
memblock allocator aligns @size to @align to reduce the amount
of fragmentation. Commit:
7bd0b0f0da ("memblock: Reimplement memblock allocation using reverse free area iterator")
Broke it by incorrectly relocating @size aligning to
memblock_find_in_range_node(). As the aligned size is not
propagated back to memblock_alloc_base_nid(), the actually
reserved size isn't aligned.
While this increases memory use for memblock reserved array,
this shouldn't cause any critical failure; however, it seems
that the size aligning was hiding a use-beyond-allocation bug in
sparc64 and losing the aligning causes boot failure.
The underlying problem is currently being debugged but this is a
proper fix in itself, it's already pretty late in -rc cycle for
boot failures and reverting the change for debugging isn't
difficult. Restore the size aligning moving it to
memblock_alloc_base_nid().
Reported-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20120228205621.GC3252@dhcp-172-17-108-109.mtv.corp.google.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <alpine.SOC.1.00.1202130942030.1488@math.ut.ee>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions