summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorQuentin Monnet <quentin.monnet@netronome.com>2018-10-21 01:01:50 +0300
committerDaniel Borkmann <daniel@iogearbox.net>2018-10-21 21:45:14 +0300
commitfe8ecccc10b3adc071de05ca7af728ca1a4ac9aa (patch)
treee331ea6c91c3da4fc356cbaed02d0cceff29bdbb /tools
parent06ee9da6a8b49e0e12b7a825dbe6ad243d5463e2 (diff)
downloadlinux-fe8ecccc10b3adc071de05ca7af728ca1a4ac9aa.tar.xz
tools: bpftool: fix completion for "bpftool map update"
When trying to complete "bpftool map update" commands, the call to printf would print an error message that would show on the command line if no map is found to complete the command line. Fix it by making sure we have map ids to complete the line with, before we try to print something. Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'tools')
-rw-r--r--tools/bpf/bpftool/bash-completion/bpftool2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
index c56545e87b0d..3f78e6404589 100644
--- a/tools/bpf/bpftool/bash-completion/bpftool
+++ b/tools/bpf/bpftool/bash-completion/bpftool
@@ -143,7 +143,7 @@ _bpftool_map_update_map_type()
local type
type=$(bpftool -jp map show $keyword $ref | \
command sed -n 's/.*"type": "\(.*\)",$/\1/p')
- printf $type
+ [[ -n $type ]] && printf $type
}
_bpftool_map_update_get_id()