From a0e35a173a86d93040d0e08f9c38526b6cf6c1d1 Mon Sep 17 00:00:00 2001 From: "Ricardo B. Marliere" Date: Sun, 4 Feb 2024 13:32:13 -0300 Subject: hsi: hsi_core: make hsi_bus_type const Now that the driver core can properly handle constant struct bus_type, move the hsi_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere Reviewed-by: Greg Kroah-Hartman Link: https://lore.kernel.org/r/20240204-bus_cleanup-hsi-v1-1-f9318131e842@marliere.net Signed-off-by: Sebastian Reichel --- drivers/hsi/hsi_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index acbf82f755a8..e3beeac8aee5 100644 --- a/drivers/hsi/hsi_core.c +++ b/drivers/hsi/hsi_core.c @@ -48,7 +48,7 @@ static int hsi_bus_match(struct device *dev, struct device_driver *driver) return false; } -static struct bus_type hsi_bus_type = { +static const struct bus_type hsi_bus_type = { .name = "hsi", .dev_groups = hsi_bus_dev_groups, .match = hsi_bus_match, -- cgit v1.2.3 From 3693760295e8c8a1a88cb3da5b178959b3cc7c75 Mon Sep 17 00:00:00 2001 From: Randy Dunlap Date: Tue, 20 Feb 2024 22:41:12 -0800 Subject: HSI: ssi_protocol: fix struct members kernel-doc warnings Fix a typo in one struct member's name and add the @work struct member to quieten kernel-doc warnings: ssi_protocol.c:144: warning: Function parameter or struct member 'work' not described in 'ssi_protocol' ssi_protocol.c:144: warning: Function parameter or struct member 'tx_usecnt' not described in 'ssi_protocol' ssi_protocol.c:144: warning: Excess struct member 'tx_usecount' description in 'ssi_protocol' Signed-off-by: Randy Dunlap Link: https://lore.kernel.org/r/20240221064112.9155-1-rdunlap@infradead.org Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/ssi_protocol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index da6a7abd584f..10926359e6d2 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -114,9 +114,10 @@ enum { * @netdev: Phonet network device * @txqueue: TX data queue * @cmdqueue: Queue of free commands + * @work: &struct work_struct for scheduled work * @cl: HSI client own reference * @link: Link for ssip_list - * @tx_usecount: Refcount to keep track the slaves that use the wake line + * @tx_usecnt: Refcount to keep track the slaves that use the wake line * @channel_id_cmd: HSI channel id for command stream * @channel_id_data: HSI channel id for data stream */ -- cgit v1.2.3