From cefa1aaa31bd7bb73a37c15ec66a9353753b2abc Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 15 Jun 2023 09:09:20 +0300 Subject: mtd: otp: clean up on error in mtd_otp_nvmem_add() Smatch complains that these error paths are missing cleanup: drivers/mtd/mtdcore.c:983 mtd_otp_nvmem_add() warn: missing unwind goto? This needs to call nvmem_unregister(mtd->otp_user_nvmem) before returning. Fixes: 3b270fac8443 ("mtd: otp: Put factory OTP/NVRAM into the entropy pool") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/fe7ef901-9571-4c6e-a40e-449046efe2c6@moroto.mountain --- drivers/mtd/mtdcore.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'drivers/mtd') diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index abf4cb58a8ab..e00b12aa5ec9 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -975,12 +975,14 @@ static int mtd_otp_nvmem_add(struct mtd_info *mtd) void *otp; otp = kmalloc(size, GFP_KERNEL); - if (!otp) - return -ENOMEM; + if (!otp) { + err = -ENOMEM; + goto err; + } err = mtd_nvmem_fact_otp_reg_read(mtd, 0, otp, size); if (err < 0) { kfree(otp); - return err; + goto err; } add_device_randomness(otp, err); kfree(otp); -- cgit v1.2.3