From 47558cbaa842c4561d08512e531b88cc92d35837 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Sat, 4 May 2024 14:26:46 +0300 Subject: remoteproc: mediatek: Fix error code in scp_rproc_init() Set the error code to ERR_PTR(-ENOMEM). Otherwise if there is an allocation failure it leads to a NULL dereference in the caller. Fixes: c08a82494500 ("remoteproc: mediatek: Support setting DRAM and IPI shared buffer sizes") Signed-off-by: Dan Carpenter Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/b2114e3c-fa64-4edb-a1ff-d2009e544c3f@moroto.mountain Signed-off-by: Mathieu Poirier --- drivers/remoteproc/mtk_scp.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/remoteproc') diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index e281d28242dd..b8498772dba1 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -1156,6 +1156,7 @@ static struct mtk_scp *scp_rproc_init(struct platform_device *pdev, scp->share_buf = kzalloc(scp_sizes->ipi_share_buffer_size, GFP_KERNEL); if (!scp->share_buf) { dev_err(dev, "Failed to allocate IPI share buffer\n"); + ret = -ENOMEM; goto release_dev_mem; } -- cgit v1.2.3