From 49446e573bf591eef71c1e8c7cf87ec19aa2569f Mon Sep 17 00:00:00 2001 From: Uwe Kleine-König Date: Tue, 21 Mar 2023 16:40:38 +0100 Subject: rpmsg: qcom_glink_rpm: Convert to platform remove callback returning void MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20230321154039.355098-3-u.kleine-koenig@pengutronix.de --- drivers/rpmsg/qcom_glink_rpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'drivers/rpmsg') diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c index f94bb7d4f1ec..357272d7062e 100644 --- a/drivers/rpmsg/qcom_glink_rpm.c +++ b/drivers/rpmsg/qcom_glink_rpm.c @@ -361,7 +361,7 @@ static int glink_rpm_probe(struct platform_device *pdev) return 0; } -static int glink_rpm_remove(struct platform_device *pdev) +static void glink_rpm_remove(struct platform_device *pdev) { struct glink_rpm *rpm = platform_get_drvdata(pdev); struct qcom_glink *glink = rpm->glink; @@ -371,8 +371,6 @@ static int glink_rpm_remove(struct platform_device *pdev) qcom_glink_native_remove(glink); mbox_free_channel(rpm->mbox_chan); - - return 0; } static const struct of_device_id glink_rpm_of_match[] = { @@ -383,7 +381,7 @@ MODULE_DEVICE_TABLE(of, glink_rpm_of_match); static struct platform_driver glink_rpm_driver = { .probe = glink_rpm_probe, - .remove = glink_rpm_remove, + .remove_new = glink_rpm_remove, .driver = { .name = "qcom_glink_rpm", .of_match_table = glink_rpm_of_match, -- cgit v1.2.3