From 99cf922692021823bd2f87aa307fa6cb28e91ad1 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 16 Jun 2021 18:04:01 +0100 Subject: scsi: elx: libefc: Fix less than zero comparison of a unsigned int The comparison of the u32 variable rc to less than zero always false because it is unsigned. Fix this by making it an int. Link: https://lore.kernel.org/r/20210616170401.15831-1-colin.king@canonical.com Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling") Signed-off-by: Colin Ian King Signed-off-by: Martin K. Petersen Addresses-Coverity: ("Unsigned compared against 0") --- drivers/scsi/elx/libefc/efc_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/scsi/elx') diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c index 31a688bce6e9..725ca2a23fb2 100644 --- a/drivers/scsi/elx/libefc/efc_device.c +++ b/drivers/scsi/elx/libefc/efc_device.c @@ -15,7 +15,7 @@ void efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id) { - u32 rc = EFC_SCSI_CALL_COMPLETE; + int rc = EFC_SCSI_CALL_COMPLETE; struct efc *efc = node->efc; node->ls_acc_oxid = ox_id; -- cgit v1.2.3