From d1a2e2cb79ca39ae879f3b839a84543f3995b96c Mon Sep 17 00:00:00 2001 From: Ariel Silver Date: Sat, 9 Mar 2024 19:47:22 +0200 Subject: Staging: rtl8192e: Declare variable with static Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?" As dm_rx_path_sel_table is used only in rtl_dm.c it should be static. Signed-off-by: Ariel Silver Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240309174722.3463-1-arielsilver77@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index c34087af973c..4c67bfe0e8ec 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = { /*------------------------Define global variable-----------------------------*/ struct dig_t dm_digtable; -struct drx_path_sel dm_rx_path_sel_table; +static struct drx_path_sel dm_rx_path_sel_table; /*------------------------Define global variable-----------------------------*/ -- cgit v1.2.3 From 44ab88bf413b5c254507e1ed865e8ba071dfc99a Mon Sep 17 00:00:00 2001 From: Michael Straube Date: Tue, 12 Mar 2024 06:18:16 +0100 Subject: staging: rtl8192e: replace variable with direct return Remove the variable rt_status from rtl92e_send_cmd_pkt() and return true/false directly to improve readability. Signed-off-by: Michael Straube Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240312051816.18717-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c index 7f0c160bc741..e470b49b0ff7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c @@ -11,7 +11,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data, u32 len) { - bool rt_status = true; struct r8192_priv *priv = rtllib_priv(dev); u16 frag_length = 0, frag_offset = 0; struct sk_buff *skb; @@ -37,10 +36,8 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data, else skb = dev_alloc_skb(frag_length + 4); - if (!skb) { - rt_status = false; - goto Failed; - } + if (!skb) + return false; memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); @@ -77,6 +74,6 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type, const void *data, } while (frag_offset < len); rtl92e_writeb(dev, TP_POLL, TP_POLL_CQ); -Failed: - return rt_status; + + return true; } -- cgit v1.2.3 From c1fa09771a09ccf2432fdeb8e5cc7c377db1d502 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:42 -0700 Subject: Staging: rtl8192e: Rename variable ReturnPoint Rename variable ReturnPoint to return_point to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 649b529657ba..08d057ab8f74 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -964,7 +964,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) MAC80211_NOLINK) && (ieee->rf_power_state == rf_on) && !ieee->is_set_key && (!ieee->proto_stoppping) && !ieee->wx_set_enc) { - if (ieee->pwr_save_ctrl.ReturnPoint == IPS_CALLBACK_NONE) + if (ieee->pwr_save_ctrl.return_point == IPS_CALLBACK_NONE) rtl92e_ips_enter(dev); } } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 6fbf11ac168f..b2b8947da89d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1051,7 +1051,7 @@ enum rt_rf_power_state { struct rt_pwr_save_ctrl { bool bSwRfProcessing; enum rt_rf_power_state eInactivePowerState; - enum ips_callback_function ReturnPoint; + enum ips_callback_function return_point; bool bLeisurePs; u8 lps_idle_count; -- cgit v1.2.3 From abfbd0f1fa839291cf58ebd8b139b860761af145 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:43 -0700 Subject: Staging: rtl8192e: Rename variable TimeStampLow Rename variable TimeStampLow to time_stamp_low to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index e3ed709a7674..480315404969 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1659,7 +1659,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats, stats->bFirstMPDU = (pDrvInfo->PartAggr == 1) && (pDrvInfo->FirstAGGR == 1); - stats->TimeStampLow = pDrvInfo->TSFL; + stats->time_stamp_low = pDrvInfo->TSFL; stats->TimeStampHigh = rtl92e_readl(dev, TSFR + 4); _rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index b2b8947da89d..72264e1ef877 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -482,7 +482,7 @@ struct rtllib_rx_stats { u16 bCRC:1; u16 bICV:1; u16 Decrypted:1; - u32 TimeStampLow; + u32 time_stamp_low; u32 TimeStampHigh; u8 RxDrvInfoSize; -- cgit v1.2.3 From 5f6479090534efbadc762464e48d9056729dd642 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:44 -0700 Subject: Staging: rtl8192e: Rename variable TimeStampHigh Rename variable TimeStampHigh to time_stamp_high to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 480315404969..15b0ac6e6eef 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1660,7 +1660,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats, (pDrvInfo->FirstAGGR == 1); stats->time_stamp_low = pDrvInfo->TSFL; - stats->TimeStampHigh = rtl92e_readl(dev, TSFR + 4); + stats->time_stamp_high = rtl92e_readl(dev, TSFR + 4); _rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo); skb_trim(skb, skb->len - S_CRC_LEN); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 72264e1ef877..e165f1e32e7f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -483,7 +483,7 @@ struct rtllib_rx_stats { u16 bICV:1; u16 Decrypted:1; u32 time_stamp_low; - u32 TimeStampHigh; + u32 time_stamp_high; u8 RxDrvInfoSize; u8 RxBufShift; -- cgit v1.2.3 From 7ea8ae9e19a07d37fc00786d46189f27b092b5be Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:45 -0700 Subject: Staging: rtl8192e: Rename variable Frame_Order Rename variable Frame_Order frame_order to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index fa96a2c2c916..dd0e2931b9ca 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -625,7 +625,7 @@ EXPORT_SYMBOL(HT_update_self_and_peer_setting); u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame) { if (ieee->ht_info->current_ht_support) { - if ((IsQoSDataFrame(pFrame) && Frame_Order(pFrame)) == 1) { + if ((IsQoSDataFrame(pFrame) && frame_order(pFrame)) == 1) { netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n"); return true; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index e165f1e32e7f..748bb25cbd23 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -343,7 +343,7 @@ enum rt_op_mode { #define IsQoSDataFrame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) == \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) -#define Frame_Order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER) +#define frame_order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER) #define SN_LESS(a, b) (((a-b)&0x800) != 0) #define SN_EQUAL(a, b) (a == b) #define MAX_DEV_ADDR_SIZE 8 -- cgit v1.2.3 From c3f253ef02eaa80493bbe24c618812fc2d86408b Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:46 -0700 Subject: Staging: rtl8192e: Rename variable aSifsTime Rename variable aSifsTime to asifs_time to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 15b0ac6e6eef..dcb78cd2e840 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -130,7 +130,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, u8 *val) &priv->rtllib->current_network.qos_data.parameters; u1bAIFS = qop->aifs[pAcParam] * - ((mode & (WIRELESS_MODE_G | WIRELESS_MODE_N_24G)) ? 9 : 20) + aSifsTime; + ((mode & (WIRELESS_MODE_G | WIRELESS_MODE_N_24G)) ? 9 : 20) + asifs_time; rtl92e_dm_init_edca_turbo(dev); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 748bb25cbd23..640fb8abcfa3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -299,7 +299,7 @@ enum rt_op_mode { RT_OP_MODE_NO_LINK, }; -#define aSifsTime \ +#define asifs_time \ ((priv->rtllib->current_network.mode == WIRELESS_MODE_N_24G) ? 16 : 10) #define MGMT_QUEUE_NUM 5 -- cgit v1.2.3 From 8f3d126901b744e12523912aa5d5491be3eda846 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:47 -0700 Subject: Staging: rtl8192e: Rename variable posHTCap Rename variable posHTCap to pos_ht_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index dd0e2931b9ca..1c3ef1b7ebd8 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -235,7 +235,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, - "%s(): posHTCap and ht_info are null\n", __func__); + "%s(): pos_ht_cap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 640fb8abcfa3..525242b0313f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1736,7 +1736,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee, enum ht_extchnl_offset Offset); void ht_update_default_setting(struct rtllib_device *ieee); void ht_construct_capability_element(struct rtllib_device *ieee, - u8 *posHTCap, u8 *len, + u8 *pos_ht_cap, u8 *len, u8 isEncrypt, bool bAssoc); void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg, u8 *len); -- cgit v1.2.3 From 9c46c813905a7fda51b18111c03b690a0e307c9f Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:48 -0700 Subject: Staging: rtl8192e: Rename variable bRTSUseShortPreamble Rename variable bRTSUseShortPreamble to rts_use_short_preamble to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index dcb78cd2e840..41373c013299 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -900,7 +900,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, pTxFwInfo->RtsBandwidth = 0; pTxFwInfo->RtsSubcarrier = cb_desc->RTSSC; pTxFwInfo->RtsShort = (pTxFwInfo->RtsHT == 0) ? - (cb_desc->bRTSUseShortPreamble ? 1 : 0) : + (cb_desc->rts_use_short_preamble ? 1 : 0) : (cb_desc->bRTSUseShortGI ? 1 : 0); if (priv->current_chnl_bw == HT_CHANNEL_WIDTH_20_40) { if (cb_desc->bPacketBW) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 525242b0313f..cf75d1225501 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -121,7 +121,7 @@ struct cb_desc { u8 bRTSBW:1; u8 bPacketBW:1; - u8 bRTSUseShortPreamble:1; + u8 rts_use_short_preamble:1; u8 bRTSUseShortGI:1; u8 multicast:1; u8 bBroadcast:1; -- cgit v1.2.3 From 9cfe5964787fed5933e3695043f24ba28a5199fe Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:49 -0700 Subject: Staging: rtl8192e: Rename variable pBssHT Rename variable pBssHT to bss_ht to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++++++++++---------- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 1c3ef1b7ebd8..618523bacc8e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -543,19 +543,19 @@ void ht_initialize_ht_info(struct rtllib_device *ieee) } } -void ht_initialize_bss_desc(struct bss_ht *pBssHT) +void ht_initialize_bss_desc(struct bss_ht *bss_ht) { - pBssHT->bd_support_ht = false; - memset(pBssHT->bd_ht_cap_buf, 0, sizeof(pBssHT->bd_ht_cap_buf)); - pBssHT->bd_ht_cap_len = 0; - memset(pBssHT->bd_ht_info_buf, 0, sizeof(pBssHT->bd_ht_info_buf)); - pBssHT->bd_ht_info_len = 0; + bss_ht->bd_support_ht = false; + memset(bss_ht->bd_ht_cap_buf, 0, sizeof(bss_ht->bd_ht_cap_buf)); + bss_ht->bd_ht_cap_len = 0; + memset(bss_ht->bd_ht_info_buf, 0, sizeof(bss_ht->bd_ht_info_buf)); + bss_ht->bd_ht_info_len = 0; - pBssHT->bd_ht_spec_ver = HT_SPEC_VER_IEEE; + bss_ht->bd_ht_spec_ver = HT_SPEC_VER_IEEE; - pBssHT->bd_rt2rt_aggregation = false; - pBssHT->bd_rt2rt_long_slot_time = false; - pBssHT->rt2rt_ht_mode = (enum rt_ht_capability)0; + bss_ht->bd_rt2rt_aggregation = false; + bss_ht->bd_rt2rt_long_slot_time = false; + bss_ht->rt2rt_ht_mode = (enum rt_ht_capability)0; } void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee, diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index cf75d1225501..3819a859710d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1742,7 +1742,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg, u8 *len); void ht_on_assoc_rsp(struct rtllib_device *ieee); void ht_initialize_ht_info(struct rtllib_device *ieee); -void ht_initialize_bss_desc(struct bss_ht *pBssHT); +void ht_initialize_bss_desc(struct bss_ht *bss_ht); void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, -- cgit v1.2.3 From decc6f8ce18fc4017625678af417685839d06628 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:50 -0700 Subject: Staging: rtl8192e: Rename variable bAllowAllDA Rename variable bAllowAllDA to allow_all_da to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 41373c013299..e3276d2c3616 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -702,12 +702,12 @@ void rtl92e_link_change(struct net_device *dev) } } -void rtl92e_set_monitor_mode(struct net_device *dev, bool bAllowAllDA, +void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, bool WriteIntoReg) { struct r8192_priv *priv = rtllib_priv(dev); - if (bAllowAllDA) + if (allow_all_da) priv->receive_config |= RCR_AAP; else priv->receive_config &= ~RCR_AAP; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h index 878c96236824..1224f190937e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h @@ -21,7 +21,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, u8 *val); void rtl92e_get_eeprom_size(struct net_device *dev); bool rtl92e_start_adapter(struct net_device *dev); void rtl92e_link_change(struct net_device *dev); -void rtl92e_set_monitor_mode(struct net_device *dev, bool bAllowAllDA, +void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, bool WriteIntoReg); void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, struct cb_desc *cb_desc, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 3819a859710d..393fff7e6a8d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1477,7 +1477,7 @@ struct rtllib_device { void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val); void (*allow_all_dest_addr_handler)(struct net_device *dev, - bool bAllowAllDA, + bool allow_all_da, bool WriteIntoReg); void (*rtllib_ips_leave_wq)(struct net_device *dev); -- cgit v1.2.3 From ab8e210d16b10e01b40fedde18de413434310784 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 10 Mar 2024 16:55:51 -0700 Subject: Staging: rtl8192e: Rename variable WriteIntoReg Rename variable WriteIntoReg to write_into_reg to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240310235552.4217-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index e3276d2c3616..fdf8fc66939d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -703,7 +703,7 @@ void rtl92e_link_change(struct net_device *dev) } void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg) + bool write_into_reg) { struct r8192_priv *priv = rtllib_priv(dev); @@ -712,7 +712,7 @@ void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, else priv->receive_config &= ~RCR_AAP; - if (WriteIntoReg) + if (write_into_reg) rtl92e_writel(dev, RCR, priv->receive_config); } diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h index 1224f190937e..9d9c5051c7fe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h @@ -22,7 +22,7 @@ void rtl92e_get_eeprom_size(struct net_device *dev); bool rtl92e_start_adapter(struct net_device *dev); void rtl92e_link_change(struct net_device *dev); void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg); + bool write_into_reg); void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, struct cb_desc *cb_desc, struct sk_buff *skb); void rtl92e_fill_tx_cmd_desc(struct net_device *dev, struct tx_desc_cmd *entry, diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 393fff7e6a8d..0809af3fd041 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1478,7 +1478,7 @@ struct rtllib_device { void (*allow_all_dest_addr_handler)(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg); + bool write_into_reg); void (*rtllib_ips_leave_wq)(struct net_device *dev); void (*rtllib_ips_leave)(struct net_device *dev); -- cgit v1.2.3 From 30b6e72b15091134a1e33d95470d27f447260b47 Mon Sep 17 00:00:00 2001 From: Michael Straube Date: Fri, 29 Mar 2024 12:14:58 +0100 Subject: staging: rtl8192e: remove unnecessary wrapper _rtl92e_dm_ctrl_initgain_byrssi() is just a wrapper around _rtl92e_dm_ctrl_initgain_byrssi_driver(). Using a wrapper here adds no value, remove it. Keep the name _rtl92e_dm_ctrl_initgain_byrssi(). Signed-off-by: Michael Straube Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240329111458.14961-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index 4c67bfe0e8ec..aebe67f1a46d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -163,7 +163,6 @@ static void _rtl92e_dm_check_tx_power_tracking(struct net_device *dev); static void _rtl92e_dm_dig_init(struct net_device *dev); static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev); -static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev); static void _rtl92e_dm_initial_gain(struct net_device *dev); static void _rtl92e_dm_pd_th(struct net_device *dev); static void _rtl92e_dm_cs_ratio(struct net_device *dev); @@ -929,11 +928,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) dm_digtable.rx_gain_range_min = DM_DIG_MIN; } -static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) -{ - _rtl92e_dm_ctrl_initgain_byrssi_driver(dev); -} - /*----------------------------------------------------------------------------- * Function: dm_CtrlInitGainBeforeConnectByRssiAndFalseAlarm() * @@ -952,7 +946,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) * ******************************************************************************/ -static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev) +static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) { struct r8192_priv *priv = rtllib_priv(dev); u8 i; -- cgit v1.2.3 From 01742a4052f71f601be8d1e27c0b43bc3df6a1f1 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:49 -0700 Subject: Staging: rtl8192e: Rename variable CurSTAExtChnlOffset Rename variable CurSTAExtChnlOffset to cur_sta_ext_chnl_offset to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index a4580445305d..eeb5a5eb94be 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -109,7 +109,7 @@ struct rt_hi_throughput { u8 forced_ampdu_factor; u8 forced_mpdu_density; u8 current_op_mode; - enum ht_extchnl_offset CurSTAExtChnlOffset; + enum ht_extchnl_offset cur_sta_ext_chnl_offset; u8 cur_tx_bw40mhz; u8 sw_bw_in_progress; u8 current_rt2rt_aggregation; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 618523bacc8e..e82e8c50c090 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -638,10 +638,10 @@ static void ht_set_connect_bw_mode_callback(struct rtllib_device *ieee) struct rt_hi_throughput *ht_info = ieee->ht_info; if (ht_info->cur_bw_40mhz) { - if (ht_info->CurSTAExtChnlOffset == HT_EXTCHNL_OFFSET_UPPER) + if (ht_info->cur_sta_ext_chnl_offset == HT_EXTCHNL_OFFSET_UPPER) ieee->set_chan(ieee->dev, ieee->current_network.channel + 2); - else if (ht_info->CurSTAExtChnlOffset == + else if (ht_info->cur_sta_ext_chnl_offset == HT_EXTCHNL_OFFSET_LOWER) ieee->set_chan(ieee->dev, ieee->current_network.channel - 2); @@ -650,7 +650,7 @@ static void ht_set_connect_bw_mode_callback(struct rtllib_device *ieee) ieee->current_network.channel); ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20_40, - ht_info->CurSTAExtChnlOffset); + ht_info->cur_sta_ext_chnl_offset); } else { ieee->set_chan(ieee->dev, ieee->current_network.channel); ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, @@ -680,14 +680,14 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee, if (Offset == HT_EXTCHNL_OFFSET_UPPER || Offset == HT_EXTCHNL_OFFSET_LOWER) { ht_info->cur_bw_40mhz = true; - ht_info->CurSTAExtChnlOffset = Offset; + ht_info->cur_sta_ext_chnl_offset = Offset; } else { ht_info->cur_bw_40mhz = false; - ht_info->CurSTAExtChnlOffset = HT_EXTCHNL_OFFSET_NO_EXT; + ht_info->cur_sta_ext_chnl_offset = HT_EXTCHNL_OFFSET_NO_EXT; } } else { ht_info->cur_bw_40mhz = false; - ht_info->CurSTAExtChnlOffset = HT_EXTCHNL_OFFSET_NO_EXT; + ht_info->cur_sta_ext_chnl_offset = HT_EXTCHNL_OFFSET_NO_EXT; } netdev_dbg(ieee->dev, "%s():ht_info->bCurBW40MHz:%x\n", __func__, diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c index d6bc74ba9092..11542aea4a20 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -319,7 +319,7 @@ void rtllib_wx_sync_scan_wq(void *data) if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht && ieee->ht_info->cur_bw_40mhz) { b40M = 1; - chan_offset = ieee->ht_info->CurSTAExtChnlOffset; + chan_offset = ieee->ht_info->cur_sta_ext_chnl_offset; bandwidth = (enum ht_channel_width)ieee->ht_info->cur_bw_40mhz; ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); -- cgit v1.2.3 From f72a077852bf7121e10059c762d52253f8a7a126 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:50 -0700 Subject: Staging: rtl8192e: Rename variable CurrentAMPDUFactor Rename variable CurrentAMPDUFactor to current_ampdu_factor to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++---- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index eeb5a5eb94be..b789d0f17156 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -104,7 +104,7 @@ struct rt_hi_throughput { u8 ampdu_enable; u8 current_ampdu_enable; u8 ampdu_factor; - u8 CurrentAMPDUFactor; + u8 current_ampdu_factor; u8 current_mpdu_density; u8 forced_ampdu_factor; u8 forced_mpdu_density; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index e82e8c50c090..3982c37f208c 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -470,12 +470,12 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) if (ieee->current_network.bssht.bd_rt2rt_aggregation) { if (ieee->pairwise_key_type != KEY_TYPE_NA) - ht_info->CurrentAMPDUFactor = + ht_info->current_ampdu_factor = pPeerHTCap->MaxRxAMPDUFactor; else - ht_info->CurrentAMPDUFactor = HT_AGG_SIZE_64K; + ht_info->current_ampdu_factor = HT_AGG_SIZE_64K; } else { - ht_info->CurrentAMPDUFactor = min_t(u32, pPeerHTCap->MaxRxAMPDUFactor, + ht_info->current_ampdu_factor = min_t(u32, pPeerHTCap->MaxRxAMPDUFactor, HT_AGG_SIZE_32K); } @@ -514,7 +514,7 @@ void ht_initialize_ht_info(struct rtllib_device *ieee) ht_info->cur_short_gi_40mhz = false; ht_info->current_mpdu_density = 0; - ht_info->CurrentAMPDUFactor = ht_info->ampdu_factor; + ht_info->current_ampdu_factor = ht_info->ampdu_factor; memset((void *)(&ht_info->self_ht_cap), 0, sizeof(ht_info->self_ht_cap)); diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 54100dd81505..1aeb207a3fee 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -313,7 +313,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device *ieee, } if (ieee->iw_mode == IW_MODE_INFRA) { tcb_desc->ampdu_enable = true; - tcb_desc->ampdu_factor = ht_info->CurrentAMPDUFactor; + tcb_desc->ampdu_factor = ht_info->current_ampdu_factor; tcb_desc->ampdu_density = ht_info->current_mpdu_density; } } -- cgit v1.2.3 From b45d48dcb18ff0201cfe3be7118c8dfa83397422 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:51 -0700 Subject: Staging: rtl8192e: Rename variable OptMode Rename variable OptMode to opt_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index b789d0f17156..d8fb2bda91e4 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -62,7 +62,7 @@ struct ht_info_ele { u8 PSMPAccessOnly:1; u8 SrvIntGranularity:3; - u8 OptMode:2; + u8 opt_mode:2; u8 NonGFDevPresent:1; u8 Revd1:5; u8 Revd2:8; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 3982c37f208c..837911934462 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -498,7 +498,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) pMcsFilter); ieee->HTCurrentOperaRate = ieee->HTHighestOperaRate; - ht_info->current_op_mode = pPeerHTInfo->OptMode; + ht_info->current_op_mode = pPeerHTInfo->opt_mode; } void ht_initialize_ht_info(struct rtllib_device *ieee) @@ -617,7 +617,7 @@ void HT_update_self_and_peer_setting(struct rtllib_device *ieee, if (ht_info->current_ht_support) { if (pNetwork->bssht.bd_ht_info_len != 0) - ht_info->current_op_mode = pPeerHTInfo->OptMode; + ht_info->current_op_mode = pPeerHTInfo->opt_mode; } } EXPORT_SYMBOL(HT_update_self_and_peer_setting); -- cgit v1.2.3 From fb3ac10f25f92ba6ce8a26870745ab09283b4644 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:52 -0700 Subject: Staging: rtl8192e: Rename variable LSigTxopProtect Rename variable LSigTxopProtect to lsig_txop_protect to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index d8fb2bda91e4..7e0f64df01ea 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -37,7 +37,7 @@ struct ht_capab_ele { u8 DssCCk:1; u8 PSMP:1; u8 Rsvd1:1; - u8 LSigTxopProtect:1; + u8 lsig_txop_protect:1; u8 MaxRxAMPDUFactor:2; u8 MPDUDensity:3; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 837911934462..503ea1e92a7d 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -268,7 +268,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; cap_ele->DssCCk = 1; cap_ele->PSMP = 0; - cap_ele->LSigTxopProtect = 0; + cap_ele->lsig_txop_protect = 0; netdev_dbg(ieee->dev, "TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n", -- cgit v1.2.3 From b5c085767bc6d66fdee9feb4ecff3c2170f34001 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:53 -0700 Subject: Staging: rtl8192e: Rename variable ChlWidth Rename variable ChlWidth to chl_width to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +++++----- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 7e0f64df01ea..938be9c27e0b 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -25,7 +25,7 @@ enum ht_extchnl_offset { struct ht_capab_ele { u8 AdvCoding:1; - u8 ChlWidth:1; + u8 chl_width:1; u8 MimoPwrSave:2; u8 GreenField:1; u8 ShortGI20Mhz:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 503ea1e92a7d..b79ea0b42e44 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -253,9 +253,9 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->AdvCoding = 0; if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) - cap_ele->ChlWidth = 0; + cap_ele->chl_width = 0; else - cap_ele->ChlWidth = 1; + cap_ele->chl_width = 1; cap_ele->MimoPwrSave = 3; cap_ele->GreenField = 0; @@ -272,7 +272,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, netdev_dbg(ieee->dev, "TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n", - cap_ele->ChlWidth, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); + cap_ele->chl_width, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); if (is_encrypt) { cap_ele->MPDUDensity = 7; @@ -302,7 +302,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->ShortGI40Mhz = 0; if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) { - cap_ele->ChlWidth = 0; + cap_ele->chl_width = 0; cap_ele->MCS[1] = 0; } } @@ -452,7 +452,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) print_hex_dump_bytes("%s: ", __func__, DUMP_PREFIX_NONE, pPeerHTCap, sizeof(struct ht_capab_ele)); #endif - ht_set_connect_bw_mode(ieee, (enum ht_channel_width)(pPeerHTCap->ChlWidth), + ht_set_connect_bw_mode(ieee, (enum ht_channel_width)(pPeerHTCap->chl_width), (enum ht_extchnl_offset)(pPeerHTInfo->ExtChlOffset)); ht_info->cur_tx_bw40mhz = ((pPeerHTInfo->RecommemdedTxWidth == 1) ? true : false); diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index ebf8a2fd36d3..ee469c9118b8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1877,7 +1877,7 @@ static void rtllib_parse_mfie_ht_cap(struct rtllib_info_element *info_element, ht->bd_bandwidth = (enum ht_channel_width) (((struct ht_capab_ele *) - (ht->bd_ht_cap_buf))->ChlWidth); + (ht->bd_ht_cap_buf))->chl_width); } else { ht->bd_support_ht = false; ht->bd_ht_1r = false; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c index 55a3e4222cd6..1cfd109881ad 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -129,8 +129,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, else ht_cap = (struct ht_capab_ele *) &network->bssht.bd_ht_cap_buf[0]; - is40M = (ht_cap->ChlWidth) ? 1 : 0; - isShortGI = (ht_cap->ChlWidth) ? + is40M = (ht_cap->chl_width) ? 1 : 0; + isShortGI = (ht_cap->chl_width) ? ((ht_cap->ShortGI40Mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); -- cgit v1.2.3 From 571acd1719c19d971b51a2108f934dd53c6ea4ef Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:54 -0700 Subject: Staging: rtl8192e: Rename variable AdvCoding Rename variable AdvCoding to adv_coding to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 938be9c27e0b..fb3c0dba9d16 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -24,7 +24,7 @@ enum ht_extchnl_offset { }; struct ht_capab_ele { - u8 AdvCoding:1; + u8 adv_coding:1; u8 chl_width:1; u8 MimoPwrSave:2; u8 GreenField:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index b79ea0b42e44..6eb708ba80ae 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -251,7 +251,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, *len = 26 + 2; } - cap_ele->AdvCoding = 0; + cap_ele->adv_coding = 0; if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) cap_ele->chl_width = 0; else -- cgit v1.2.3 From 3b6f3b7e084ad6a7f27b737668723b35b3adf9fb Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:55 -0700 Subject: Staging: rtl8192e: Rename variable MimoPwrSave Rename variable MimoPwrSave to mimo_pwr_save to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index fb3c0dba9d16..25cdfdf85991 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -26,7 +26,7 @@ enum ht_extchnl_offset { struct ht_capab_ele { u8 adv_coding:1; u8 chl_width:1; - u8 MimoPwrSave:2; + u8 mimo_pwr_save:2; u8 GreenField:1; u8 ShortGI20Mhz:1; u8 ShortGI40Mhz:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 6eb708ba80ae..73d1e19a59ba 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -257,7 +257,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, else cap_ele->chl_width = 1; - cap_ele->MimoPwrSave = 3; + cap_ele->mimo_pwr_save = 3; cap_ele->GreenField = 0; cap_ele->ShortGI20Mhz = 1; cap_ele->ShortGI40Mhz = 1; -- cgit v1.2.3 From d4a0d94585cffd5bd4e119a3c6a7f26d3d4d4a76 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:56 -0700 Subject: Staging: rtl8192e: Rename variable ShortGI40Mhz Rename variable ShortGI40Mhz to short_gi_40mhz to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 25cdfdf85991..1b08507cab87 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -29,7 +29,7 @@ struct ht_capab_ele { u8 mimo_pwr_save:2; u8 GreenField:1; u8 ShortGI20Mhz:1; - u8 ShortGI40Mhz:1; + u8 short_gi_40mhz:1; u8 TxSTBC:1; u8 RxSTBC:2; u8 DelayBA:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 73d1e19a59ba..6c557717d8af 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -260,7 +260,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->mimo_pwr_save = 3; cap_ele->GreenField = 0; cap_ele->ShortGI20Mhz = 1; - cap_ele->ShortGI40Mhz = 1; + cap_ele->short_gi_40mhz = 1; cap_ele->TxSTBC = 1; cap_ele->RxSTBC = 0; @@ -299,7 +299,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->MCS[1] &= 0x00; if (ht->iot_action & HT_IOT_ACT_DISABLE_RX_40MHZ_SHORT_GI) - cap_ele->ShortGI40Mhz = 0; + cap_ele->short_gi_40mhz = 0; if (ieee->get_half_nmode_support_by_aps_handler(ieee->dev)) { cap_ele->chl_width = 0; @@ -458,7 +458,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) true : false); ht_info->cur_short_gi_20mhz = ((pPeerHTCap->ShortGI20Mhz == 1) ? true : false); - ht_info->cur_short_gi_40mhz = ((pPeerHTCap->ShortGI40Mhz == 1) ? true : false); + ht_info->cur_short_gi_40mhz = ((pPeerHTCap->short_gi_40mhz == 1) ? true : false); ht_info->current_ampdu_enable = ht_info->ampdu_enable; if (ieee->rtllib_ap_sec_type && diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c index 1cfd109881ad..71ecfd0c8ed7 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -131,7 +131,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, &network->bssht.bd_ht_cap_buf[0]; is40M = (ht_cap->chl_width) ? 1 : 0; isShortGI = (ht_cap->chl_width) ? - ((ht_cap->ShortGI40Mhz) ? 1 : 0) : + ((ht_cap->short_gi_40mhz) ? 1 : 0) : ((ht_cap->ShortGI20Mhz) ? 1 : 0); max_mcs = ht_get_highest_mcs_rate(ieee, ht_cap->MCS, -- cgit v1.2.3 From b55af8ba3cf68a6d7e45ba1ceb280b9a2cb1ec72 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:57 -0700 Subject: Staging: rtl8192e: Rename variable ShortGI20Mhz Rename variable ShortGI20Mhz to short_gi_20mhz to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 1b08507cab87..008611e3aace 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -28,7 +28,7 @@ struct ht_capab_ele { u8 chl_width:1; u8 mimo_pwr_save:2; u8 GreenField:1; - u8 ShortGI20Mhz:1; + u8 short_gi_20mhz:1; u8 short_gi_40mhz:1; u8 TxSTBC:1; u8 RxSTBC:2; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 6c557717d8af..3b1c6e24103e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -259,7 +259,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->mimo_pwr_save = 3; cap_ele->GreenField = 0; - cap_ele->ShortGI20Mhz = 1; + cap_ele->short_gi_20mhz = 1; cap_ele->short_gi_40mhz = 1; cap_ele->TxSTBC = 1; @@ -457,7 +457,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) ht_info->cur_tx_bw40mhz = ((pPeerHTInfo->RecommemdedTxWidth == 1) ? true : false); - ht_info->cur_short_gi_20mhz = ((pPeerHTCap->ShortGI20Mhz == 1) ? true : false); + ht_info->cur_short_gi_20mhz = ((pPeerHTCap->short_gi_20mhz == 1) ? true : false); ht_info->cur_short_gi_40mhz = ((pPeerHTCap->short_gi_40mhz == 1) ? true : false); ht_info->current_ampdu_enable = ht_info->ampdu_enable; diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c index 71ecfd0c8ed7..fbd4ec824084 100644 --- a/drivers/staging/rtl8192e/rtllib_wx.c +++ b/drivers/staging/rtl8192e/rtllib_wx.c @@ -132,7 +132,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, is40M = (ht_cap->chl_width) ? 1 : 0; isShortGI = (ht_cap->chl_width) ? ((ht_cap->short_gi_40mhz) ? 1 : 0) : - ((ht_cap->ShortGI20Mhz) ? 1 : 0); + ((ht_cap->short_gi_20mhz) ? 1 : 0); max_mcs = ht_get_highest_mcs_rate(ieee, ht_cap->MCS, MCS_FILTER_ALL); -- cgit v1.2.3 From 86272f2bbf642a1d42384b84a1ad013a02f56728 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:58 -0700 Subject: Staging: rtl8192e: Rename variable GreenField Rename variable GreenField to green_field to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 008611e3aace..b9f50d195b13 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -27,7 +27,7 @@ struct ht_capab_ele { u8 adv_coding:1; u8 chl_width:1; u8 mimo_pwr_save:2; - u8 GreenField:1; + u8 green_field:1; u8 short_gi_20mhz:1; u8 short_gi_40mhz:1; u8 TxSTBC:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 3b1c6e24103e..cf3536fdefbd 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -258,7 +258,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->chl_width = 1; cap_ele->mimo_pwr_save = 3; - cap_ele->GreenField = 0; + cap_ele->green_field = 0; cap_ele->short_gi_20mhz = 1; cap_ele->short_gi_40mhz = 1; -- cgit v1.2.3 From d6e0eabdb5d32992f26c21869f06748b9cec92a1 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:00:59 -0700 Subject: Staging: rtl8192e: Rename variable TxSTBC Rename variable TxSTBC to tx_stbc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index b9f50d195b13..bd66df620793 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -30,7 +30,7 @@ struct ht_capab_ele { u8 green_field:1; u8 short_gi_20mhz:1; u8 short_gi_40mhz:1; - u8 TxSTBC:1; + u8 tx_stbc:1; u8 RxSTBC:2; u8 DelayBA:1; u8 MaxAMSDUSize:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index cf3536fdefbd..d51a0daa9196 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -262,7 +262,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->short_gi_20mhz = 1; cap_ele->short_gi_40mhz = 1; - cap_ele->TxSTBC = 1; + cap_ele->tx_stbc = 1; cap_ele->RxSTBC = 0; cap_ele->DelayBA = 0; cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; -- cgit v1.2.3 From 982c4a8b5a5b00f66029af2acf87821dfa6aaa47 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:00 -0700 Subject: Staging: rtl8192e: Rename variable RxSTBC Rename variable RxSTBC to rx_stbc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index bd66df620793..3f8860e91793 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -31,7 +31,7 @@ struct ht_capab_ele { u8 short_gi_20mhz:1; u8 short_gi_40mhz:1; u8 tx_stbc:1; - u8 RxSTBC:2; + u8 rx_stbc:2; u8 DelayBA:1; u8 MaxAMSDUSize:1; u8 DssCCk:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index d51a0daa9196..91c7415d5a2a 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -263,7 +263,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->short_gi_40mhz = 1; cap_ele->tx_stbc = 1; - cap_ele->RxSTBC = 0; + cap_ele->rx_stbc = 0; cap_ele->DelayBA = 0; cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; cap_ele->DssCCk = 1; -- cgit v1.2.3 From 165bb7d4d002cb650aa6d21b8e6f8bd6cc0945f5 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:01 -0700 Subject: Staging: rtl8192e: Rename variable DelayBA Rename variable DelayBA to delay_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 3f8860e91793..96973c744cd0 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -32,7 +32,7 @@ struct ht_capab_ele { u8 short_gi_40mhz:1; u8 tx_stbc:1; u8 rx_stbc:2; - u8 DelayBA:1; + u8 delay_ba:1; u8 MaxAMSDUSize:1; u8 DssCCk:1; u8 PSMP:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 91c7415d5a2a..5c920a0089c9 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -264,7 +264,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->tx_stbc = 1; cap_ele->rx_stbc = 0; - cap_ele->DelayBA = 0; + cap_ele->delay_ba = 0; cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; cap_ele->DssCCk = 1; cap_ele->PSMP = 0; -- cgit v1.2.3 From 9d2953b958a24b31c632d8c60f988b8b7aa7f940 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:02 -0700 Subject: Staging: rtl8192e: Rename variable MaxAMSDUSize Rename variable MaxAMSDUSize to max_amsdu_size to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 96973c744cd0..e0906e4588c2 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -33,7 +33,7 @@ struct ht_capab_ele { u8 tx_stbc:1; u8 rx_stbc:2; u8 delay_ba:1; - u8 MaxAMSDUSize:1; + u8 max_amsdu_size:1; u8 DssCCk:1; u8 PSMP:1; u8 Rsvd1:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 5c920a0089c9..7b08e549726b 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -265,14 +265,14 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->tx_stbc = 1; cap_ele->rx_stbc = 0; cap_ele->delay_ba = 0; - cap_ele->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; + cap_ele->max_amsdu_size = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; cap_ele->DssCCk = 1; cap_ele->PSMP = 0; cap_ele->lsig_txop_protect = 0; netdev_dbg(ieee->dev, - "TX HT cap/info ele BW=%d MaxAMSDUSize:%d DssCCk:%d\n", - cap_ele->chl_width, cap_ele->MaxAMSDUSize, cap_ele->DssCCk); + "TX HT cap/info ele BW=%d max_amsdu_size:%d DssCCk:%d\n", + cap_ele->chl_width, cap_ele->max_amsdu_size, cap_ele->DssCCk); if (is_encrypt) { cap_ele->MPDUDensity = 7; -- cgit v1.2.3 From 1f630607e62682c1350c9c4904223cca2114d1b8 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:03 -0700 Subject: Staging: rtl8192e: Rename variable MaxRxAMPDUFactor Rename variable MaxRxAMPDUFactor to max_rx_ampdu_factor to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index e0906e4588c2..425df93486b3 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -39,7 +39,7 @@ struct ht_capab_ele { u8 Rsvd1:1; u8 lsig_txop_protect:1; - u8 MaxRxAMPDUFactor:2; + u8 max_rx_ampdu_factor:2; u8 MPDUDensity:3; u8 Rsvd2:3; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 7b08e549726b..516e48073dc7 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -276,9 +276,9 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, if (is_encrypt) { cap_ele->MPDUDensity = 7; - cap_ele->MaxRxAMPDUFactor = 2; + cap_ele->max_rx_ampdu_factor = 2; } else { - cap_ele->MaxRxAMPDUFactor = 3; + cap_ele->max_rx_ampdu_factor = 3; cap_ele->MPDUDensity = 0; } @@ -471,12 +471,12 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) if (ieee->current_network.bssht.bd_rt2rt_aggregation) { if (ieee->pairwise_key_type != KEY_TYPE_NA) ht_info->current_ampdu_factor = - pPeerHTCap->MaxRxAMPDUFactor; + pPeerHTCap->max_rx_ampdu_factor; else ht_info->current_ampdu_factor = HT_AGG_SIZE_64K; } else { - ht_info->current_ampdu_factor = min_t(u32, pPeerHTCap->MaxRxAMPDUFactor, - HT_AGG_SIZE_32K); + ht_info->current_ampdu_factor = min_t(u32, pPeerHTCap->max_rx_ampdu_factor, + HT_AGG_SIZE_32K); } ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity; -- cgit v1.2.3 From a0667f7d7db06e5d182a2108022968ad31043b7e Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:04 -0700 Subject: Staging: rtl8192e: Rename variable MPDUDensity Rename variable MPDUDensity to mpdu_density to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 425df93486b3..5cea0d8ee544 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -40,7 +40,7 @@ struct ht_capab_ele { u8 lsig_txop_protect:1; u8 max_rx_ampdu_factor:2; - u8 MPDUDensity:3; + u8 mpdu_density:3; u8 Rsvd2:3; u8 MCS[16]; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 516e48073dc7..85f52d09304d 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -275,11 +275,11 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->chl_width, cap_ele->max_amsdu_size, cap_ele->DssCCk); if (is_encrypt) { - cap_ele->MPDUDensity = 7; + cap_ele->mpdu_density = 7; cap_ele->max_rx_ampdu_factor = 2; } else { cap_ele->max_rx_ampdu_factor = 3; - cap_ele->MPDUDensity = 0; + cap_ele->mpdu_density = 0; } memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); @@ -479,7 +479,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) HT_AGG_SIZE_32K); } - ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity; + ht_info->current_mpdu_density = pPeerHTCap->mpdu_density; if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) ht_info->current_ampdu_enable = false; -- cgit v1.2.3 From 3f9a84460ffd5def456726f8514cb91acda9afee Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:05 -0700 Subject: Staging: rtl8192e: Rename variable ExtHTCapInfo Rename variable ExtHTCapInfo to ext_ht_cap_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 5cea0d8ee544..c1446081956d 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -45,7 +45,7 @@ struct ht_capab_ele { u8 MCS[16]; - u16 ExtHTCapInfo; + u16 ext_ht_cap_info; u8 TxBFCap[4]; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 85f52d09304d..963d69680049 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -283,7 +283,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, } memcpy(cap_ele->MCS, ieee->reg_dot11ht_oper_rate_set, 16); - memset(&cap_ele->ExtHTCapInfo, 0, 2); + memset(&cap_ele->ext_ht_cap_info, 0, 2); memset(cap_ele->TxBFCap, 0, 4); cap_ele->ASCap = 0; -- cgit v1.2.3 From bae502410013af607b9a766469360eab3a0409e5 Mon Sep 17 00:00:00 2001 From: Tree Davies Date: Sun, 28 Apr 2024 16:01:06 -0700 Subject: Staging: rtl8192e: Rename variable DssCCk Rename variable DssCCk to dss_cck to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann Link: https://lore.kernel.org/r/20240428230106.6548-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/staging/rtl8192e') diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index c1446081956d..a6e0077630c7 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -34,7 +34,7 @@ struct ht_capab_ele { u8 rx_stbc:2; u8 delay_ba:1; u8 max_amsdu_size:1; - u8 DssCCk:1; + u8 dss_cck:1; u8 PSMP:1; u8 Rsvd1:1; u8 lsig_txop_protect:1; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c index 963d69680049..9b0a981f6f22 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -266,13 +266,13 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, cap_ele->rx_stbc = 0; cap_ele->delay_ba = 0; cap_ele->max_amsdu_size = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; - cap_ele->DssCCk = 1; + cap_ele->dss_cck = 1; cap_ele->PSMP = 0; cap_ele->lsig_txop_protect = 0; netdev_dbg(ieee->dev, - "TX HT cap/info ele BW=%d max_amsdu_size:%d DssCCk:%d\n", - cap_ele->chl_width, cap_ele->max_amsdu_size, cap_ele->DssCCk); + "TX HT cap/info ele BW=%d max_amsdu_size:%d dss_cck:%d\n", + cap_ele->chl_width, cap_ele->max_amsdu_size, cap_ele->dss_cck); if (is_encrypt) { cap_ele->mpdu_density = 7; -- cgit v1.2.3