diff options
| author | Atish Patra <atish.patra@wdc.com> | 2019-02-28 04:42:17 +0300 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2019-03-05 11:35:12 +0300 |
| commit | 86cc9b8633bea3bc6fbda145424f871ea553af9e (patch) | |
| tree | dd63e0eee35ed225059db03f36405842715792bb /include | |
| parent | 05602e2bf4812533adcb7acb1a67e43726c0e7bb (diff) | |
| download | opensbi-86cc9b8633bea3bc6fbda145424f871ea553af9e.tar.xz | |
lib:platform: Fix sbi_getc return type.
As per the current SBI specification, sbi_getc should return
an int instead of char.
In case of FIFO is empty, return -1 as per the specification.
Reported-by: Sergi Granell <xerpi.g.12@gmail.com>
Suggested-by:Thadeu Lima de Souza Cascardo <cascardo@cascardo.eti.br>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sbi/sbi_console.h | 2 | ||||
| -rw-r--r-- | include/sbi/sbi_platform.h | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/include/sbi/sbi_console.h b/include/sbi/sbi_console.h index 8069669..0fd58e7 100644 --- a/include/sbi/sbi_console.h +++ b/include/sbi/sbi_console.h @@ -16,7 +16,7 @@ bool sbi_isprintable(char ch); -char sbi_getc(void); +int sbi_getc(void); void sbi_putc(char ch); diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h index 8f4f44b..fe04c2f 100644 --- a/include/sbi/sbi_platform.h +++ b/include/sbi/sbi_platform.h @@ -77,7 +77,7 @@ struct sbi_platform { /** Write a character to the platform console output */ void (*console_putc)(char ch); /** Read a character from the platform console input */ - char (*console_getc)(void); + int (*console_getc)(void); /** Initialize the platform console */ int (*console_init)(void); @@ -283,11 +283,11 @@ static inline void sbi_platform_console_putc(struct sbi_platform *plat, * * @return character read from console input */ -static inline char sbi_platform_console_getc(struct sbi_platform *plat) +static inline int sbi_platform_console_getc(struct sbi_platform *plat) { if (plat && plat->console_getc) return plat->console_getc(); - return 0; + return -1; } /** |