summaryrefslogtreecommitdiff
path: root/lib/sbi
diff options
context:
space:
mode:
authorAnup Patel <anup.patel@wdc.com>2021-04-21 15:33:50 +0300
committerAnup Patel <anup@brainfault.org>2021-04-28 14:28:23 +0300
commit068ca086af2312d56efe51a724d78d84e1339ab4 (patch)
tree0e90c1a9e7a03254ff5dcb33507c5c9a06f9de3e /lib/sbi
parenta3689db92a0e83ef25c52887aa686e4527e35a22 (diff)
downloadopensbi-068ca086af2312d56efe51a724d78d84e1339ab4.tar.xz
lib: sbi: Simplify console platform operations
Instead of having console_putc() and console_getc() callbacks in platform operations, it will be much simpler for console driver to directly register these operations as device to the sbi_console implementation. Signed-off-by: Anup Patel <anup.patel@wdc.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Xiang W <wxjstz@126.com>
Diffstat (limited to 'lib/sbi')
-rw-r--r--lib/sbi/sbi_console.c31
1 files changed, 23 insertions, 8 deletions
diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index 7189b9b..b54f7a2 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -12,7 +12,7 @@
#include <sbi/sbi_platform.h>
#include <sbi/sbi_scratch.h>
-static const struct sbi_platform *console_plat = NULL;
+static const struct sbi_console_device *console_dev = NULL;
static spinlock_t console_out_lock = SPIN_LOCK_INITIALIZER;
bool sbi_isprintable(char c)
@@ -26,14 +26,18 @@ bool sbi_isprintable(char c)
int sbi_getc(void)
{
- return sbi_platform_console_getc(console_plat);
+ if (console_dev && console_dev->console_getc)
+ return console_dev->console_getc();
+ return -1;
}
void sbi_putc(char ch)
{
- if (ch == '\n')
- sbi_platform_console_putc(console_plat, '\r');
- sbi_platform_console_putc(console_plat, ch);
+ if (console_dev && console_dev->console_putc) {
+ if (ch == '\n')
+ console_dev->console_putc('\r');
+ console_dev->console_putc(ch);
+ }
}
void sbi_puts(const char *str)
@@ -390,9 +394,20 @@ int sbi_dprintf(const char *format, ...)
return retval;
}
-int sbi_console_init(struct sbi_scratch *scratch)
+const struct sbi_console_device *sbi_console_get_device(void)
+{
+ return console_dev;
+}
+
+void sbi_console_set_device(const struct sbi_console_device *dev)
{
- console_plat = sbi_platform_ptr(scratch);
+ if (!dev || console_dev)
+ return;
- return sbi_platform_console_init(console_plat);
+ console_dev = dev;
+}
+
+int sbi_console_init(struct sbi_scratch *scratch)
+{
+ return sbi_platform_console_init(sbi_platform_ptr(scratch));
}