diff options
| author | Atish Patra <atish.patra@wdc.com> | 2019-02-28 04:42:17 +0300 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2019-03-05 11:35:12 +0300 |
| commit | 86cc9b8633bea3bc6fbda145424f871ea553af9e (patch) | |
| tree | dd63e0eee35ed225059db03f36405842715792bb /platform/kendryte | |
| parent | 05602e2bf4812533adcb7acb1a67e43726c0e7bb (diff) | |
| download | opensbi-86cc9b8633bea3bc6fbda145424f871ea553af9e.tar.xz | |
lib:platform: Fix sbi_getc return type.
As per the current SBI specification, sbi_getc should return
an int instead of char.
In case of FIFO is empty, return -1 as per the specification.
Reported-by: Sergi Granell <xerpi.g.12@gmail.com>
Suggested-by:Thadeu Lima de Souza Cascardo <cascardo@cascardo.eti.br>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
Diffstat (limited to 'platform/kendryte')
| -rw-r--r-- | platform/kendryte/k210/platform.c | 2 | ||||
| -rw-r--r-- | platform/kendryte/k210/uarths.c | 4 | ||||
| -rw-r--r-- | platform/kendryte/k210/uarths.h | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/platform/kendryte/k210/platform.c b/platform/kendryte/k210/platform.c index f1e19b7..104edcc 100644 --- a/platform/kendryte/k210/platform.c +++ b/platform/kendryte/k210/platform.c @@ -31,7 +31,7 @@ static void k210_console_putc(char c) uarths_putc(c); } -static char k210_console_getc(void) +static int k210_console_getc(void) { return uarths_getc(); } diff --git a/platform/kendryte/k210/uarths.c b/platform/kendryte/k210/uarths.c index f8f4974..34fcf39 100644 --- a/platform/kendryte/k210/uarths.c +++ b/platform/kendryte/k210/uarths.c @@ -48,12 +48,12 @@ void uarths_putc(char c) uarths->txdata.data = (u8)c; } -char uarths_getc(void) +int uarths_getc(void) { struct uarths_rxdata rx = uarths->rxdata; if (rx.empty) - return '\0'; + return -1; return rx.data; } diff --git a/platform/kendryte/k210/uarths.h b/platform/kendryte/k210/uarths.h index dd0433c..f247a63 100644 --- a/platform/kendryte/k210/uarths.h +++ b/platform/kendryte/k210/uarths.h @@ -161,6 +161,6 @@ enum uarths_stopbit { void uarths_init(u32 baud_rate, enum uarths_stopbit stopbit); void uarths_putc(char c); -char uarths_getc(void); +int uarths_getc(void); #endif /* _K210_UARTHS_H_ */ |