summaryrefslogtreecommitdiff
path: root/platform
diff options
context:
space:
mode:
authorAnup Patel <anup.patel@wdc.com>2020-05-12 07:44:43 +0300
committerAnup Patel <anup@brainfault.org>2020-05-23 08:06:26 +0300
commit73d6ef3b2933ccf0b3a8a0ba110bf53ad9720b51 (patch)
treebaa3468336030b1680162ed4e31d3a3fa6d89179 /platform
parent89ba63493c4ce98861144180e408d6db391fd1c3 (diff)
downloadopensbi-73d6ef3b2933ccf0b3a8a0ba110bf53ad9720b51.tar.xz
lib: utils: Remove redundant parameters from PLIC init functions
The "target_hart" and "hart_count" parameters of PLIC cold and warm init functions are only used for sanity checks and not required in PLIC initialization. Signed-off-by: Anup Patel <anup.patel@wdc.com> Reviewed-by: Atish Patra <atish.patra@wdc.com>
Diffstat (limited to 'platform')
-rw-r--r--platform/andes/ae350/platform.c5
-rw-r--r--platform/fpga/ariane/platform.c11
-rw-r--r--platform/fpga/openpiton/platform.c11
-rw-r--r--platform/kendryte/k210/platform.c5
-rw-r--r--platform/nuclei/ux600/platform.c5
-rw-r--r--platform/sifive/fu540/platform.c5
-rw-r--r--platform/template/platform.c5
7 files changed, 16 insertions, 31 deletions
diff --git a/platform/andes/ae350/platform.c b/platform/andes/ae350/platform.c
index 774ea90..16443fb 100644
--- a/platform/andes/ae350/platform.c
+++ b/platform/andes/ae350/platform.c
@@ -71,13 +71,12 @@ static int ae350_irqchip_init(bool cold_boot)
if (cold_boot) {
ret = plic_cold_irqchip_init(AE350_PLIC_ADDR,
- AE350_PLIC_NUM_SOURCES,
- AE350_HART_COUNT);
+ AE350_PLIC_NUM_SOURCES);
if (ret)
return ret;
}
- return plic_warm_irqchip_init(hartid, 2 * hartid, 2 * hartid + 1);
+ return plic_warm_irqchip_init(2 * hartid, 2 * hartid + 1);
}
/* Initialize IPI for current HART. */
diff --git a/platform/fpga/ariane/platform.c b/platform/fpga/ariane/platform.c
index ba9ef9d..c3f3f65 100644
--- a/platform/fpga/ariane/platform.c
+++ b/platform/fpga/ariane/platform.c
@@ -63,13 +63,10 @@ static int ariane_console_init(void)
ARIANE_UART_REG_WIDTH);
}
-static int plic_ariane_warm_irqchip_init(u32 target_hart,
- int m_cntx_id, int s_cntx_id)
+static int plic_ariane_warm_irqchip_init(int m_cntx_id, int s_cntx_id)
{
size_t i, ie_words = ARIANE_PLIC_NUM_SOURCES / 32 + 1;
- if (ARIANE_HART_COUNT <= target_hart)
- return -1;
/* By default, enable all IRQs for M-mode of target HART */
if (m_cntx_id > -1) {
for (i = 0; i < ie_words; i++)
@@ -99,14 +96,12 @@ static int ariane_irqchip_init(bool cold_boot)
int ret;
if (cold_boot) {
- ret = plic_cold_irqchip_init(ARIANE_PLIC_ADDR,
- ARIANE_PLIC_NUM_SOURCES,
+ ret = plic_cold_irqchip_init(ARIANE_PLIC_NUM_SOURCES,
ARIANE_HART_COUNT);
if (ret)
return ret;
}
- return plic_ariane_warm_irqchip_init(hartid,
- 2 * hartid, 2 * hartid + 1);
+ return plic_ariane_warm_irqchip_init(2 * hartid, 2 * hartid + 1);
}
/*
diff --git a/platform/fpga/openpiton/platform.c b/platform/fpga/openpiton/platform.c
index 776ca35..781da17 100644
--- a/platform/fpga/openpiton/platform.c
+++ b/platform/fpga/openpiton/platform.c
@@ -95,13 +95,10 @@ static int openpiton_console_init(void)
OPENPITON_DEFAULT_UART_REG_WIDTH);
}
-static int plic_openpiton_warm_irqchip_init(u32 target_hart,
- int m_cntx_id, int s_cntx_id)
+static int plic_openpiton_warm_irqchip_init(int m_cntx_id, int s_cntx_id)
{
size_t i, ie_words = plic.num_src / 32 + 1;
- if (target_hart >= OPENPITON_DEFAULT_HART_COUNT)
- return -1;
/* By default, enable all IRQs for M-mode of target HART */
if (m_cntx_id > -1) {
for (i = 0; i < ie_words; i++)
@@ -132,13 +129,11 @@ static int openpiton_irqchip_init(bool cold_boot)
if (cold_boot) {
ret = plic_cold_irqchip_init(plic.addr,
- plic.num_src,
- OPENPITON_DEFAULT_HART_COUNT);
+ plic.num_src);
if (ret)
return ret;
}
- return plic_openpiton_warm_irqchip_init(hartid,
- 2 * hartid, 2 * hartid + 1);
+ return plic_openpiton_warm_irqchip_init(2 * hartid, 2 * hartid + 1);
}
/*
diff --git a/platform/kendryte/k210/platform.c b/platform/kendryte/k210/platform.c
index 69c0e21..c852e7f 100644
--- a/platform/kendryte/k210/platform.c
+++ b/platform/kendryte/k210/platform.c
@@ -59,13 +59,12 @@ static int k210_irqchip_init(bool cold_boot)
if (cold_boot) {
rc = plic_cold_irqchip_init(K210_PLIC_BASE_ADDR,
- K210_PLIC_NUM_SOURCES,
- K210_HART_COUNT);
+ K210_PLIC_NUM_SOURCES);
if (rc)
return rc;
}
- return plic_warm_irqchip_init(hartid, hartid * 2, hartid * 2 + 1);
+ return plic_warm_irqchip_init(hartid * 2, hartid * 2 + 1);
}
static int k210_ipi_init(bool cold_boot)
diff --git a/platform/nuclei/ux600/platform.c b/platform/nuclei/ux600/platform.c
index 6c8bf4d..914cf99 100644
--- a/platform/nuclei/ux600/platform.c
+++ b/platform/nuclei/ux600/platform.c
@@ -74,13 +74,12 @@ static int ux600_irqchip_init(bool cold_boot)
if (cold_boot) {
rc = plic_cold_irqchip_init(UX600_PLIC_ADDR,
- UX600_PLIC_NUM_SOURCES,
- UX600_HART_COUNT);
+ UX600_PLIC_NUM_SOURCES);
if (rc)
return rc;
}
- return plic_warm_irqchip_init(hartid, (hartid) ? (2 * hartid - 1) : 0,
+ return plic_warm_irqchip_init((hartid) ? (2 * hartid - 1) : 0,
(hartid) ? (2 * hartid) : -1);
}
diff --git a/platform/sifive/fu540/platform.c b/platform/sifive/fu540/platform.c
index aeb2f41..bef17f1 100644
--- a/platform/sifive/fu540/platform.c
+++ b/platform/sifive/fu540/platform.c
@@ -89,13 +89,12 @@ static int fu540_irqchip_init(bool cold_boot)
if (cold_boot) {
rc = plic_cold_irqchip_init(FU540_PLIC_ADDR,
- FU540_PLIC_NUM_SOURCES,
- FU540_HART_COUNT);
+ FU540_PLIC_NUM_SOURCES);
if (rc)
return rc;
}
- return plic_warm_irqchip_init(hartid, (hartid) ? (2 * hartid - 1) : 0,
+ return plic_warm_irqchip_init((hartid) ? (2 * hartid - 1) : 0,
(hartid) ? (2 * hartid) : -1);
}
diff --git a/platform/template/platform.c b/platform/template/platform.c
index 84fbf56..3a3bdac 100644
--- a/platform/template/platform.c
+++ b/platform/template/platform.c
@@ -71,13 +71,12 @@ static int platform_irqchip_init(bool cold_boot)
/* Example if the generic PLIC driver is used */
if (cold_boot) {
ret = plic_cold_irqchip_init(PLATFORM_PLIC_ADDR,
- PLATFORM_PLIC_NUM_SOURCES,
- PLATFORM_HART_COUNT);
+ PLATFORM_PLIC_NUM_SOURCES);
if (ret)
return ret;
}
- return plic_warm_irqchip_init(hartid, 2 * hartid, 2 * hartid + 1);
+ return plic_warm_irqchip_init(2 * hartid, 2 * hartid + 1);
}
/*