From d6d7e18d1d12c8eda2591f21a70d31dd95c2d32e Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Wed, 4 Mar 2020 14:30:49 +0530 Subject: lib: sbi_init: Don't allow HARTID greater than SBI_HARTMASK_MAX_BITS We only allow HARTs with HARTID less than SBI_HARTMASK_MAX_BITS in sbi_init() function so that sbi_hartmask can safely used across OpenSBI sources. Signed-off-by: Anup Patel Reviewed-by: Bin Meng Reviewed-by: Atish Patra --- lib/sbi/sbi_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c index 1f113b9..9a9e433 100644 --- a/lib/sbi/sbi_init.c +++ b/lib/sbi/sbi_init.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -215,7 +216,8 @@ void __noreturn sbi_init(struct sbi_scratch *scratch) u32 hartid = sbi_current_hartid(); const struct sbi_platform *plat = sbi_platform_ptr(scratch); - if (sbi_platform_hart_disabled(plat, hartid)) + if ((SBI_HARTMASK_MAX_BITS <= hartid) || + sbi_platform_hart_disabled(plat, hartid)) sbi_hart_hang(); if (atomic_add_return(&coldboot_lottery, 1) == 1) -- cgit v1.2.3