From 813f7f4c250af9f7c9546f64778e9b35bb7d7dcb Mon Sep 17 00:00:00 2001 From: Xiang W Date: Wed, 27 Nov 2019 14:16:52 +0800 Subject: lib: Add error detection for misa_extension Add assertions for misa_extension to prevent incoming illegal characters. Signed-off-by: Xiang Wang Reviewed-by: Anup Patel --- include/sbi/riscv_asm.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) (limited to 'include') diff --git a/include/sbi/riscv_asm.h b/include/sbi/riscv_asm.h index 04502e1..c3d5985 100644 --- a/include/sbi/riscv_asm.h +++ b/include/sbi/riscv_asm.h @@ -159,8 +159,16 @@ void csr_write_num(int csr_num, unsigned long val); __asm__ __volatile__("wfi" ::: "memory"); \ } while (0) -/* Determine CPU extension, return non-zero support */ -int misa_extension(char ext); + +/* determine CPU extension, return non-zero support */ +int misa_extension_imp(char ext); + +#define misa_extension(c)\ +({\ + _Static_assert(((c >= 'A') && (c <= 'Z')),\ + "The parameter of misa_extension must be [A-Z]");\ + misa_extension_imp(c);\ +}) /* Get MXL field of misa, return -1 on error */ int misa_xlen(void); @@ -170,7 +178,7 @@ static inline void misa_string(char *out, unsigned int out_sz) unsigned long i; for (i = 0; i < 26; i++) { - if (misa_extension('A' + i)) { + if (misa_extension_imp('A' + i)) { *out = 'A' + i; out++; } -- cgit v1.2.3