From 99017946f36525c0689d287fbad21426575944c4 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Mon, 21 Jun 2021 21:37:54 +0200 Subject: lib: sign conflict in wake_coldboot_harts() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Compiling wake_coldboot_harts() with GCC 11 and -Wextra yields: lib/sbi/sbi_init.c:208:27: error: comparison of integer expressions of different signedness: ‘int’ and ‘u32’ {aka ‘unsigned int’} [-Werror=sign-compare] 208 | for (int i = 0; i <= sbi_scratch_last_hartid(); i++) { | ^~ Signed-off-by: Heinrich Schuchardt Reviewed-by: Atish Patra Reviewed-by: Xiang W --- lib/sbi/sbi_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c index b158314..e396d95 100644 --- a/lib/sbi/sbi_init.c +++ b/lib/sbi/sbi_init.c @@ -205,7 +205,7 @@ static void wake_coldboot_harts(struct sbi_scratch *scratch, u32 hartid) spin_lock(&coldboot_lock); /* Send an IPI to all HARTs waiting for coldboot */ - for (int i = 0; i <= sbi_scratch_last_hartid(); i++) { + for (u32 i = 0; i <= sbi_scratch_last_hartid(); i++) { if ((i != hartid) && sbi_hartmask_test_hart(i, &coldboot_wait_hmask)) sbi_ipi_raw_send(i); -- cgit v1.2.3