diff options
author | Pali Rohár <pali@kernel.org> | 2021-08-27 15:14:43 +0300 |
---|---|---|
committer | Stefan Roese <sr@denx.de> | 2021-09-10 10:01:51 +0300 |
commit | 758262bc266aa65cfbfd74033c3ac1e4e67c92ec (patch) | |
tree | 52ad2de40404a89322d069f8610fd7a1f4e05690 | |
parent | 88426bd6b08e42ce3ca2b1b9c3e11e5c390c3020 (diff) | |
download | u-boot-758262bc266aa65cfbfd74033c3ac1e4e67c92ec.tar.xz |
arm: a37xx: pci: Disable returning CRS response
There was mistake in commit 4cd61c43fd51 ("arm: a37xx: pci: Fix handling
PIO config error responses"). U-Boot does not support handling of CRS
return value for PCI_VENDOR_ID config read request and also does not set
CRSSVE bit.
Therefore disable returning CRS response for now.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 4cd61c43fd51 ("arm: a37xx: pci: Fix handling PIO config error responses")
Reviewed-by: Stefan Roese <sr@denx.de>
-rw-r--r-- | drivers/pci/pci-aardvark.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c index 815b26162f..d3ef8f203d 100644 --- a/drivers/pci/pci-aardvark.c +++ b/drivers/pci/pci-aardvark.c @@ -358,7 +358,18 @@ static int pcie_advk_read_config(const struct udevice *bus, pci_dev_t bdf, return 0; } - allow_crs = (offset == PCI_VENDOR_ID) && (size == 4); + /* + * Returning fabricated CRS value (0xFFFF0001) by PCIe Root Complex to + * OS is allowed only for 4-byte PCI_VENDOR_ID config read request and + * only when CRSSVE bit in Root Port PCIe device is enabled. In all + * other error PCIe Root Complex must return all-ones. + * Aardvark HW does not have Root Port PCIe device and U-Boot does not + * implement emulation of this device. + * U-Boot currently does not support handling of CRS return value for + * PCI_VENDOR_ID config read request and also does not set CRSSVE bit. + * Therefore disable returning CRS response for now. + */ + allow_crs = false; if (advk_readl(pcie, PIO_START)) { dev_err(pcie->dev, |