summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2018-01-30 16:07:05 +0300
committerTom Rini <trini@konsulko.com>2018-02-06 04:58:12 +0300
commita43aebee89acf57b4e22018f401cffc9fef4fd85 (patch)
treed11542becec249f06e7d252d672b145818f2be5b
parentc631e150feb150cff744c12d5e54b609ba62a227 (diff)
downloadu-boot-a43aebee89acf57b4e22018f401cffc9fef4fd85.tar.xz
usb: ulpi: kconfig: Remove meaningless choice default
'default' on a choice refers to the symbol selected by default, not to the choice mode, so 'default n' is meaningless. No functional changes. Optional choices implicitly default to n mode (and there is no way to make them default to another mode). Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib), which prints the following warning: warning: the default selection n (undefined) of <choice> (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice I've added a corresponding warning to the C tools too, which is currently in linux-next: https://patchwork.kernel.org/patch/9983667/ Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
-rw-r--r--drivers/usb/ulpi/Kconfig1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig
index 329d2df3ed..001564d40c 100644
--- a/drivers/usb/ulpi/Kconfig
+++ b/drivers/usb/ulpi/Kconfig
@@ -3,7 +3,6 @@ comment "ULPI drivers"
choice
prompt "ULPI Viewport type"
optional
- default n
help
Select ULPI viewport (SoC-side interface to ULPI) implementation
appropriate for the device if you want to communicate with