diff options
| author | Simon Glass <sjg@chromium.org> | 2018-11-24 07:29:29 +0300 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2018-12-05 16:01:34 +0300 |
| commit | a65d1a06c9f76d3285948a059b861d7534589cfc (patch) | |
| tree | ea14f430006a34818ec82fe630f84dcafa5bb0a2 /arch/sandbox/cpu | |
| parent | 2a07269062a8e63dadc23be0f8b0d4638da7d2d2 (diff) | |
| download | u-boot-a65d1a06c9f76d3285948a059b861d7534589cfc.tar.xz | |
sandbox: Zero the ram buffer on startup
At present the RAM buffer is not inited unless it is read from a file,
likely produced by an earlier phase of U-Boot. This causes valgrind
warnings whenever the RAM buffer is used. Correct this by initing it if
needed.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'arch/sandbox/cpu')
| -rw-r--r-- | arch/sandbox/cpu/start.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c index b1566a8143..2f5e6e9518 100644 --- a/arch/sandbox/cpu/start.c +++ b/arch/sandbox/cpu/start.c @@ -180,6 +180,7 @@ static int sandbox_cmdline_cb_memory(struct sandbox_state *state, printf("Failed to read RAM buffer '%s': %d\n", arg, err); return err; } + state->ram_buf_read = true; return 0; } @@ -301,6 +302,12 @@ int board_run_command(const char *cmdline) static void setup_ram_buf(struct sandbox_state *state) { + /* Zero the RAM buffer if we didn't read it, to keep valgrind happy */ + if (!state->ram_buf_read) { + memset(state->ram_buf, '\0', state->ram_size); + printf("clear %p %x\n", state->ram_buf, state->ram_size); + } + gd->arch.ram_buf = state->ram_buf; gd->ram_size = state->ram_size; } |