diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 09:13:33 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 16:30:13 +0300 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/armltd | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.xz | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/armltd')
| -rw-r--r-- | board/armltd/integrator/integrator.c | 2 | ||||
| -rw-r--r-- | board/armltd/vexpress/vexpress_common.c | 4 | ||||
| -rw-r--r-- | board/armltd/vexpress/vexpress_tc2.c | 2 | ||||
| -rw-r--r-- | board/armltd/vexpress64/vexpress64.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/board/armltd/integrator/integrator.c b/board/armltd/integrator/integrator.c index ac6462d7ff..19871bee14 100644 --- a/board/armltd/integrator/integrator.c +++ b/board/armltd/integrator/integrator.c @@ -174,7 +174,7 @@ extern void dram_query(void); } #ifdef CONFIG_CMD_NET -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_SMC91111 diff --git a/board/armltd/vexpress/vexpress_common.c b/board/armltd/vexpress/vexpress_common.c index 9dc26b949e..70f6cd80d5 100644 --- a/board/armltd/vexpress/vexpress_common.c +++ b/board/armltd/vexpress/vexpress_common.c @@ -64,7 +64,7 @@ int board_init(void) return 0; } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_SMC911X @@ -73,7 +73,7 @@ int board_eth_init(bd_t *bis) return rc; } -int cpu_mmc_init(bd_t *bis) +int cpu_mmc_init(struct bd_info *bis) { int rc = 0; (void) bis; diff --git a/board/armltd/vexpress/vexpress_tc2.c b/board/armltd/vexpress/vexpress_tc2.c index 5278ef784f..8ee24bdde7 100644 --- a/board/armltd/vexpress/vexpress_tc2.c +++ b/board/armltd/vexpress/vexpress_tc2.c @@ -36,7 +36,7 @@ bool armv7_boot_nonsec_default(void) } #ifdef CONFIG_OF_BOARD_SETUP -int ft_board_setup(void *fdt, bd_t *bd) +int ft_board_setup(void *fdt, struct bd_info *bd) { int offset, tmp, len; const struct fdt_property *prop; diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c index 5932a4a0c7..52ada0f6bc 100644 --- a/board/armltd/vexpress64/vexpress64.c +++ b/board/armltd/vexpress64/vexpress64.c @@ -149,7 +149,7 @@ void reset_cpu(ulong addr) /* * Board specific ethernet initialization routine. */ -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifndef CONFIG_DM_ETH |