diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 09:13:33 +0300 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 16:30:13 +0300 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/broadcom | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
| download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.xz | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/broadcom')
| -rw-r--r-- | board/broadcom/bcm23550_w1d/bcm23550_w1d.c | 2 | ||||
| -rw-r--r-- | board/broadcom/bcm28155_ap/bcm28155_ap.c | 2 | ||||
| -rw-r--r-- | board/broadcom/bcm_ep/board.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/board/broadcom/bcm23550_w1d/bcm23550_w1d.c b/board/broadcom/bcm23550_w1d/bcm23550_w1d.c index cff9a6840c..a1e3b25c2e 100644 --- a/board/broadcom/bcm23550_w1d/bcm23550_w1d.c +++ b/board/broadcom/bcm23550_w1d/bcm23550_w1d.c @@ -76,7 +76,7 @@ int dram_init_banksize(void) /* * mmc_init - Initializes mmc */ -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int ret = 0; diff --git a/board/broadcom/bcm28155_ap/bcm28155_ap.c b/board/broadcom/bcm28155_ap/bcm28155_ap.c index e3bf808d7e..79ce54993d 100644 --- a/board/broadcom/bcm28155_ap/bcm28155_ap.c +++ b/board/broadcom/bcm28155_ap/bcm28155_ap.c @@ -83,7 +83,7 @@ int dram_init_banksize(void) /* * mmc_init - Initializes mmc */ -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { int ret = 0; diff --git a/board/broadcom/bcm_ep/board.c b/board/broadcom/bcm_ep/board.c index 31cae47028..ad9af92b55 100644 --- a/board/broadcom/bcm_ep/board.c +++ b/board/broadcom/bcm_ep/board.c @@ -75,7 +75,7 @@ void smp_waitloop(unsigned previous_address) #endif #ifdef CONFIG_BCM_SF2_ETH -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = -1; printf("Registering BCM sf2 eth\n"); |