diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 09:13:33 +0300 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 16:30:13 +0300 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/freescale/t208xrdb | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.xz |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/freescale/t208xrdb')
-rw-r--r-- | board/freescale/t208xrdb/eth_t208xrdb.c | 2 | ||||
-rw-r--r-- | board/freescale/t208xrdb/pci.c | 2 | ||||
-rw-r--r-- | board/freescale/t208xrdb/spl.c | 6 | ||||
-rw-r--r-- | board/freescale/t208xrdb/t208xrdb.c | 2 | ||||
-rw-r--r-- | board/freescale/t208xrdb/t208xrdb.h | 2 |
5 files changed, 7 insertions, 7 deletions
diff --git a/board/freescale/t208xrdb/eth_t208xrdb.c b/board/freescale/t208xrdb/eth_t208xrdb.c index db4718128d..c16538850c 100644 --- a/board/freescale/t208xrdb/eth_t208xrdb.c +++ b/board/freescale/t208xrdb/eth_t208xrdb.c @@ -25,7 +25,7 @@ #include <fsl_dtsec.h> #include <asm/fsl_serdes.h> -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { #if defined(CONFIG_FMAN_ENET) int i, interface; diff --git a/board/freescale/t208xrdb/pci.c b/board/freescale/t208xrdb/pci.c index bd0e29744c..45ab9223ae 100644 --- a/board/freescale/t208xrdb/pci.c +++ b/board/freescale/t208xrdb/pci.c @@ -18,7 +18,7 @@ void pci_init_board(void) fsl_pcie_init_board(0); } -void pci_of_setup(void *blob, bd_t *bd) +void pci_of_setup(void *blob, struct bd_info *bd) { FT_FSL_PCI_SETUP; } diff --git a/board/freescale/t208xrdb/spl.c b/board/freescale/t208xrdb/spl.c index 27e87da409..07aab6349c 100644 --- a/board/freescale/t208xrdb/spl.c +++ b/board/freescale/t208xrdb/spl.c @@ -67,10 +67,10 @@ void board_init_f(ulong bootflag) void board_init_r(gd_t *gd, ulong dest_addr) { - bd_t *bd; + struct bd_info *bd; - bd = (bd_t *)(gd + sizeof(gd_t)); - memset(bd, 0, sizeof(bd_t)); + bd = (struct bd_info *)(gd + sizeof(gd_t)); + memset(bd, 0, sizeof(struct bd_info)); gd->bd = bd; bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR; bd->bi_memsize = CONFIG_SYS_L3_SIZE; diff --git a/board/freescale/t208xrdb/t208xrdb.c b/board/freescale/t208xrdb/t208xrdb.c index 5ba1682888..d37abb7ef3 100644 --- a/board/freescale/t208xrdb/t208xrdb.c +++ b/board/freescale/t208xrdb/t208xrdb.c @@ -114,7 +114,7 @@ int misc_init_r(void) return 0; } -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { phys_addr_t base; phys_size_t size; diff --git a/board/freescale/t208xrdb/t208xrdb.h b/board/freescale/t208xrdb/t208xrdb.h index 2f630ef1ca..22a496fb8c 100644 --- a/board/freescale/t208xrdb/t208xrdb.h +++ b/board/freescale/t208xrdb/t208xrdb.h @@ -7,6 +7,6 @@ #define __CORENET_DS_H__ void fdt_fixup_board_enet(void *blob); -void pci_of_setup(void *blob, bd_t *bd); +void pci_of_setup(void *blob, struct bd_info *bd); #endif |